Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[replaykit] Add new FinishBroadcast method to RPBroadcastSampleHandler from Xcode 8.2 beta 1 #1101

Merged
merged 1 commit into from
Nov 3, 2016
Merged

[replaykit] Add new FinishBroadcast method to RPBroadcastSampleHandler from Xcode 8.2 beta 1 #1101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/replaykit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,5 +259,9 @@ interface RPBroadcastSampleHandler {

[Export ("processSampleBuffer:withType:")]
void ProcessSampleBuffer (CMSampleBuffer sampleBuffer, RPSampleBufferType sampleBufferType);

[iOS (10,2)][TV (10,1)]
[Export ("finishBroadcastWithError:")]
void FinishBroadcast (NSError error);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if you are missing out on the error param?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, - (void)finishBroadcastWithError:(NSError *)error;. Header description suggest you're sopping the broadcast so it's likely up to the caller to say why (using an NSError)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also intro signature check should spot that... at least for a type but it would not for delegates so it's good to comment on them :)

}
}