[tests] Add a performance test using BenchmarkDotNet. #11298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spouliot
approved these changes
Apr 22, 2021
❌ Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffTest results3 tests failed, 101 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
Since CoreCLR doesn't quite work yet (crashes at launch).
rolfbjarne
added a commit
that referenced
this pull request
Apr 23, 2021
…de. (#11271) Move the xamarin_create_managed_ref internal call to managed code, to ease things with CoreCLR. In order to preserve performance, this wasn't a straight forward port. * monotouch_create_managed_ref used to detect if there already was a GCHandle for a native object. To avoid a managed->native transition, this logic has now been moved into the code that sets the GCHandle (the xamarinSetGCHandle:flags: / xamarin_set_gchandle_trampoline code), and these methods return a value saying whether the GCHandle was set or not. * xamarin_create_gchandle will check the retain count to determine whether to create a weak or a strong GCHandle for the managed object. In this particular case we should never need to create a strong GCHandle, which means that we don't need to check the retain count (saving a managed->native transition). Using the new perftest (#11298), I get very similar numbers for both old code and new code: https://gist.github.com/rolfbjarne/e0fc2ae0f21da15062b4f051138679af (multiple runs). Sometimes the old code is faster, sometimes the new code is faster (although the old code tends to be the one who wins). In any case there aren't any significant performance hits due to this change, so it should be good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.