Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iad] Remove most of the framework #11906

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Conversation

spouliot
Copy link
Contributor

Most of the API were removed in Xcode 13 beta 1.

The App Store also started to reject some of the (already deprecated)
selectors that were removed, making the API not usable anymore (even
on older versions of the OS).

Most of the API were removed in Xcode 13 beta 1.

The App Store also started to reject some of the (already deprecated)
selectors that were removed, making the API not usable anymore (even
on older versions of the OS).
@spouliot spouliot added the note-highlight Worth calling out specifically in release notes label Jun 11, 2021
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 84 tests passed.

Failed tests

  • introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4): Failed
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 4bd72e7 into c3ea9c8

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API & Generator diff

API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 84 tests passed.

Failed tests

  • introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4): Failed
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): Failed

Pipeline on Agent XAMBOT-1100.BigSur'
Merge ad31bc3 into 51f0651

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

  • introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): Failed

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 050e9ed into 77a8299

@spouliot
Copy link
Contributor Author

introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): Failed

unrelated, known issue -> https://github.com/xamarin/maccore/issues/2454

@spouliot spouliot merged commit 447c59d into xamarin:main Jun 15, 2021
@spouliot spouliot deleted the iad-removal branch June 15, 2021 00:13
@spouliot
Copy link
Contributor Author

/sudo backport d16-10

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch d16-10 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4870764 for more details.

spouliot pushed a commit to spouliot/xamarin-macios that referenced this pull request Jun 15, 2021
Most of the API were removed in Xcode 13 beta 1.

The App Store also started to reject some of the (already deprecated)
selectors that were removed, making the API not usable anymore (even
on older versions of the OS).

This is a manual backport of xamarin#11906
as the header for Xcode 12.5 are different (and xtro would fail based
on them)
spouliot added a commit that referenced this pull request Jun 15, 2021
Most of the API were removed in Xcode 13 beta 1.

The App Store also started to reject some of the (already deprecated)
selectors that were removed, making the API not usable anymore (even
on older versions of the OS).

This is a manual backport of #11906
as the header for Xcode 12.5 are different (and xtro would fail based
on them)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants