[corefoundation] Simplify CFRange
#11931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoid chaining constructors, so one can be eliminated (if the other is not used)
* Remove casts (`int` parameters does not need them for `nint` fields)
* Reduce metadata (when a `.ctor` can be eliminated, like MySingleView)
```diff
--- a.cs 2021-06-14 20:56:22.000000000 -0400
+++ b.cs 2021-06-14 20:56:25.000000000 -0400
@@ -5068,13 +5068,8 @@
public CFRange(int P_0, int P_1)
{
- this = new CFRange((long)P_0, (long)P_1);
- }
-
- public CFRange(long P_0, long P_1)
- {
- loc = (nint)P_0;
- len = (nint)P_1;
+ loc = P_0;
+ len = P_1;
}
public override string ToString()
```
dalexsoto
approved these changes
Jun 15, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
rolfbjarne
approved these changes
Jun 15, 2021
unrelated, known issue -> https://github.com/xamarin/maccore/issues/2454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intparameters does not need them fornintfields).ctorcan be eliminated, like MySingleView)