[PhotosUI] Xcode13 PhotosUI beta1 #11945
Conversation
tj-devel709
added
the
note-highlight
Add new enums into existing binding files. That way the generator will process them. That's useful in many cases, including automatic conversion of availability attributes for net6. |
| @@ -1,10 +0,0 @@ | |||
| !missing-protocol! PHContentEditingController not bound | |||
| !missing-type! PHEditingExtensionContext not bound | |||
| ## appended from unclassified file | |||
There was a problem hiding this comment.
^ hint ^ everything above this line is part of the backlog and needs a bit more validation
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
src/photosui.cs
Outdated
| [Protocol] | ||
| [Unavailable (PlatformName.MacCatalyst)] | ||
| [Advice ("This API is not available when using UIKit on macOS.")] |
There was a problem hiding this comment.
You need to remove this advice too if you remove [Unavailable (PlatformName.MacCatalyst)]
| [Advice ("This API is not available when using UIKit on macOS.")] |
src/photosui.cs
Outdated
| @@ -474,7 +478,6 @@ interface PHProjectTypeDescriptionInvalidator | |||
| [iOS (8,0)] | |||
| [NoMac][NoTV] | |||
| [DisableDefaultCtor] | |||
| [Unavailable (PlatformName.MacCatalyst)] | |||
There was a problem hiding this comment.
This doesn't look correct, the PHEditingExtensionContext type doesn't show up for Mac Catalyst: https://developer.apple.com/documentation/photokit/pheditingextensioncontext?language=objc
If it turns out it actually is available (the documentation is wrong), then you need to remove the advice on the next line too.
There was a problem hiding this comment.
I'm sorry, you are right! I had added the MacCatalyst there and since removed it, but forgot to add that Unavailable back in!
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
|
|
||
| [iOS (15,0), MacCatalyst (15,0)] | ||
| [Export ("presentLimitedLibraryPickerFromViewController:completionHandler:")] | ||
| void PresentLimitedLibraryPicker (UIViewController controller, Action<string[]> completionHandler); |
There was a problem hiding this comment.
Looking at the docs, this looks like an Async candidate: https://developer.apple.com/documentation/photokit/phphotolibrary/3752108-presentlimitedlibrarypickerfromv
There was a problem hiding this comment.
The new swift async/await makes it easy to know, from the docs:
You can call this method from synchronous code using a completion handler, as shown on this page, or you can call it as an asynchronous method that has the following declaration:
There was a problem hiding this comment.
Ah good call, are most completionHandlers a good indicator of an async method?
There was a problem hiding this comment.
Most of the time, the new docs for swift make it easier to know. Intro will complain sometimes if it has the info.
There was a problem hiding this comment.
Updated, but forgot to run the tests, I'll do that now
There was a problem hiding this comment.
Okay they look like they are passing!
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 86 tests passed 🎉Pipeline on Agent XAMBOT-1098.BigSur' |
I wasn't quite sure if I should create an enums file for this one enum introduced to the file?