[CloudKit] Add support for Xcode13 beta1. #11961

mandel-macaque · 2021-06-16T19:14:18Z

No description provided.

mandel-macaque · 2021-06-16T19:14:57Z

tests/xtro-sharpie/common-CloudKit.ignore

@@ -9,6 +9,7 @@
 ## Not intended to be used directly by client code
 !missing-protocol! CKRecordKeyValueSetting not bound
 !missing-protocol-conformance! CKRecord should conform to CKRecordKeyValueSetting (defined in 'CKRecordKeyValueSettingConformance' category)
+!missing-selector! CKRecord::encryptedValues not bound


Not to be added due to the same reason, also intro says the type cannot be loaded.

src/CloudKit/Enums.cs

src/cloudkit.cs

spouliot · 2021-06-16T19:14:44Z

src/CloudKit/Enums.cs

@@ -14,7 +14,9 @@ public enum CKAccountStatus : long {
 		CouldNotDetermine = 0,
 		Available = 1,
 		Restricted = 2,
-		NoAccount = 3
+		NoAccount = 3,
+		[Mac(12,0), iOS(15,0), TV(15,0), MacCatalyst(15,0)]


minor: space before (

but that looks like an error enum... and those, being output only, do not need availability

spouliot · 2021-06-16T19:15:51Z

src/CloudKit/Enums.cs

@@ -82,6 +84,8 @@ public enum CKErrorCode : long {
 		ParticipantMayNeedVerification = 33,
 		ResponseLost = 34,
 		AssetNotAvailable = 35,
+		[Mac(12,0), iOS(15,0), TV(15,0), MacCatalyst (15,0)]


spouliot · 2021-06-16T19:16:13Z

src/CloudKit/Enums.cs

-		[iOS (10,0), TV (10,0), Mac (10,12)] Sharing = 1 << 2,
+		[iOS (10,0), TV (10,0), Mac (10,12)]
+		Sharing = 1 << 2,
+		[Mac(12,0), iOS(15,0), TV(15,0)]


minor: space before (

spouliot · 2021-06-16T19:16:45Z

src/cloudkit.cs

@@ -115,6 +119,10 @@ interface CKShareMetadata : NSCopying, NSSecureCoding

 		[NullAllowed, Export ("rootRecord", ArgumentSemantic.Strong)]
 		CKRecord RootRecord { get; }
+
+		[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst(15,0)]


minor: space before (

spouliot · 2021-06-16T19:16:59Z

src/cloudkit.cs

@@ -129,6 +137,11 @@ interface CKShare
 		[DesignatedInitializer]
 		IntPtr Constructor (CKRecord rootRecord, CKRecordID shareID);

+		[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst(15,0)]


minor: space before (

spouliot · 2021-06-16T19:22:52Z

src/cloudkit.cs

@@ -1764,6 +1883,9 @@ interface CKDiscoverAllUserIdentitiesOperation
 		Action<NSError> Completed { get; set; }
 	}

+	[iOS (15,0), Watch (8,0), TV (15,0), Mac (12,0)]


spouliot · 2021-06-16T19:23:07Z

src/cloudkit.cs

+		[Deprecated (PlatformName.WatchOS, 8, 0, message: "Use 'PerShareParticipantCompletionHandler' instead.")]
+		[Deprecated (PlatformName.TvOS, 15, 0, message: "Use 'PerShareParticipantCompletionHandler' instead.")]
+		[Deprecated (PlatformName.iOS, 15, 0, message: "Use 'PerShareParticipantCompletionHandler' instead.")]
+		[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use 'PerShareParticipantCompletionHandler' instead.")]


spouliot · 2021-06-16T19:23:16Z

src/cloudkit.cs

 		[NullAllowed, Export ("shareParticipantFetchedBlock", ArgumentSemantic.Copy)]
 		Action<CKShareParticipant> Fetched { get; set; }

 		[NullAllowed, Export ("fetchShareParticipantsCompletionBlock", ArgumentSemantic.Copy)]
 		Action<NSError> Completed { get; set; }
+
+		[NullAllowed]
+		[iOS (15,0), Watch (8,0), TV (15,0), Mac (12,0), MacCatalyst(15,0)]


spouliot · 2021-06-16T19:23:29Z

src/cloudkit.cs

@@ -1885,5 +2016,9 @@ interface CKFetchDatabaseChangesOperation

 		[NullAllowed, Export ("fetchDatabaseChangesCompletionBlock", ArgumentSemantic.Copy)]
 		CKFetchDatabaseChangesCompletionHandler ChangesCompleted { get; set; }
+
+		[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0), MacCatalyst(15,0)]


spouliot · 2021-06-16T19:24:11Z

tests/xtro-sharpie/common-CloudKit.ignore

@@ -9,6 +9,7 @@
 ## Not intended to be used directly by client code
 !missing-protocol! CKRecordKeyValueSetting not bound
 !missing-protocol-conformance! CKRecord should conform to CKRecordKeyValueSetting (defined in 'CKRecordKeyValueSettingConformance' category)
+!missing-selector! CKRecord::encryptedValues not bound


is the comment above applicable here ?

yes, same issue.

src/cloudkit.cs

…marin-macios into cloudkit-xcode13-beta1

vs-mobiletools-engineering-service2 · 2021-06-16T23:55:42Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

introspection/watchOS 32-bits - simulator/Debug (watchOS 5.0): Failed

Pipeline on Agent XAMBOT-1097.BigSur'
Merge 8ea5c62 into e19591f

[CloudKit] Add support for Xcode13 beta1.

110bfd7

mandel-macaque added the note-highlight Worth calling out specifically in release notes label Jun 16, 2021

mandel-macaque requested a review from spouliot as a code owner June 16, 2021 19:14