-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CFNetwork] Add Xcode13 beta 1 support. #11966
[CFNetwork] Add Xcode13 beta 1 support. #11966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use CFStreamCreatePairWithSocketToCFHost
xamarin-macios/src/CoreFoundation/CFStream.cs
Line 200 in 2b7dc07
internal extern static void CFStreamCreatePairWithSocketToCFHost ( |
which is deprecated too: https://developer.apple.com/documentation/cfnetwork/1426831-cfstreamcreatepairwithsockettocf?language=objc
This shows up in xtro as well:
xamarin-macios/tests/xtro-sharpie/iOS-CoreFoundation.todo
Lines 1 to 4 in 0921ae4
!deprecated-attribute-missing! CFStreamCreatePairWithPeerSocketSignature missing a [Deprecated] attribute | |
!deprecated-attribute-missing! CFStreamCreatePairWithSocket missing a [Deprecated] attribute | |
!deprecated-attribute-missing! CFStreamCreatePairWithSocketToCFHost missing a [Deprecated] attribute | |
!deprecated-attribute-missing! CFStreamCreatePairWithSocketToHost missing a [Deprecated] attribute |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 84 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
src/CFNetwork/CFHost.cs
Outdated
[Deprecated (PlatformName.TvOS, 15, 0, message: "Use the new Network framework instead.")] | ||
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the new Network framework instead.")] | ||
[Deprecated (PlatformName.MacCatalyst, 15, 0, message: "Use the new Network framework instead.")] | ||
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the new Network framework instead.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove "new" since it's not new anymore (and that won't surface the test of time)
src/CoreFoundation/CFStream.cs
Outdated
[Deprecated (PlatformName.TvOS, 15, 0, message: "Use the new Network framework instead.")] | ||
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the new Network framework instead.")] | ||
[Deprecated (PlatformName.MacCatalyst, 15, 0, message: "Use the new Network framework instead.")] | ||
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the new Network framework instead.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
src/CoreFoundation/CFStream.cs
Outdated
[Deprecated (PlatformName.TvOS, 15, 0, message: "Use the new Network framework instead.")] | ||
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the new Network framework instead.")] | ||
[Deprecated (PlatformName.MacCatalyst, 15, 0, message: "Use the new Network framework instead.")] | ||
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the new Network framework instead.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same.
We already use "Use 'Network.framework' instead."
in a lot of other places. It would be best to use the same string to reduce the metadata size of the assembly.
You could also add it to src/ObjCRuntime/ObsoleteConstants.cs
so it's easier to avoid different string ending up inside the platform assemblies.
That would require updating (now or later) src/Security/SecureTransport.cs
and src/Security/SslConnection.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 83 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
CFHost and all its callers have been deprecated. The other deprecated APIs are not in used by Xamarin.