-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CoreLocationUI] Add new framework for Xcode13 beta1. #11979
[CoreLocationUI] Add new framework for Xcode13 beta1. #11979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
watchOS is inconsistent
if the API were not added (like headers suggest) then it should not be defined for watchOS frameworks
tools/common/Frameworks.cs
Outdated
@@ -484,6 +486,8 @@ public static Frameworks GetwatchOSFrameworks (bool is_simulator_build) | |||
|
|||
{ "Accessibility", "Accessibility", 7,0 }, | |||
{ "UniformTypeIdentifiers", "UniformTypeIdentifiers", 7,0 }, | |||
|
|||
{ "CoreLocationUI", "CoreLocationUI", 8,0 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ? it does not look like it's available for watchOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove it and add the ignore
ShareMyCurrentLocation, | ||
} | ||
|
||
[NoTV, NoMac, NoWatch, iOS (15,0), MacCatalyst (15,0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API_AVAILABLE(ios(15.0),watchos(8.0))
I guess it's not in the watchOS header ?
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 88 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
@@ -169,6 +169,8 @@ SIMLAUNCHER_FRAMEWORKS = \ | |||
-weak_framework NearbyInteraction \ | |||
\ | |||
-weak_framework AdServices \ | |||
\ | |||
-weak_framework CoreLocationUI \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for?
@@ -418,6 +418,8 @@ public static Frameworks CreateiOSFrameworks (bool is_simulator_build) | |||
|
|||
{ "AdServices", "AdServices", 14,3 }, | |||
|
|||
{ "CoreLocationUI", "CoreLocationUI", 15,0 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When do we do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a new framework is added.
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 87 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
No description provided.