Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreText] Add support for Xcode13 beta1. #11993

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

mandel-macaque
Copy link
Member

Added the invokes to be ignored as with macOS.

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Jun 21, 2021
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not implement them ?

if not, then don't label as highlight since it will go out in release notes without anything new in the release

@mandel-macaque mandel-macaque added not-notes-worthy Ignore for release notes and removed note-highlight Worth calling out specifically in release notes labels Jun 21, 2021
@mandel-macaque
Copy link
Member Author

@spouliot We ignored them in mac OS for a reason, no one has requested them. I am just following what we did in macOS. (I've removed the label.)

@spouliot
Copy link
Contributor

We ignored them in mac OS for a reason,

Yes, the API were not available cross-platform, so of limited use (unless someone provided a use case).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 85 tests passed 🎉

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 76e1793 into c778e6b

@mandel-macaque
Copy link
Member Author

@spouliot issues is, I have not found any sample from apple or any example on how to use the API. I an add it if you want, should not be too much work.

Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine ignoring them for now and if someone needs it we can always add it later

@mandel-macaque mandel-macaque merged commit 0e07b98 into xamarin:main Jun 22, 2021
@mandel-macaque mandel-macaque deleted the coretext-xcode13-beta1 branch June 22, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants