-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CoreText] Add support for Xcode13 beta1. #11993
[CoreText] Add support for Xcode13 beta1. #11993
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not implement them ?
if not, then don't label as highlight
since it will go out in release notes without anything new in the release
@spouliot We ignored them in mac OS for a reason, no one has requested them. I am just following what we did in macOS. (I've removed the label.) |
Yes, the API were not available cross-platform, so of limited use (unless someone provided a use case). |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 85 tests passed 🎉Pipeline on Agent XAMBOT-1096.BigSur' |
@spouliot issues is, I have not found any sample from apple or any example on how to use the API. I an add it if you want, should not be too much work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine ignoring them for now and if someone needs it we can always add it later
Added the invokes to be ignored as with macOS.