[Accessibility] Update bindings for Xcode 13.0 beta 1 #11998

rachelkang · 2021-06-21T22:36:24Z

No description provided.

spouliot

needs a few changes, mostly minor :)

src/Accessibility/AXHearingUtilities.cs

spouliot · 2021-06-21T23:29:37Z

src/accessibility.cs

+
+	[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0)]
+	[Protocol]
+	[BaseType (typeof(NSObject))]


no [BaseType] unless there's a [Model]

By "unless there's a [Model]", do you mean unless the class inherits from another class, or unless the class literally has the attribute [Model]? And how do we know when the tag is needed?

He means the attribute, since Model will create an instance.

The [Model] attribute, you only add [Model], [BaseType] and [Protocol] to types with a suffix Delegate or DataSource so FooDelegate and FooDataSource will need the 3 of them any other @protocol just needs the [Protocol] attribute.

gotcha, thanks for clarifying!

Should I also remove the attribute from existing types in the file, or just let them be?

I may be wrong, but I think we try to leave things already there alone unless it causes an issue

Do not remove existing attributes since it will be a breaking change

src/accessibility.cs

spouliot · 2021-06-21T23:37:39Z

src/accessibility.cs

+	}
+
+	[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0)]
+	[BaseType (typeof(NSObject))]


since it's only static members you should add [DisableDefaultCtor] since creating an instance of this type is not helpful (and can be confusing)

Do we need BaseType?

src/accessibility.cs

vs-mobiletools-engineering-service2 · 2021-06-22T02:37:18Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

8 tests failed, 78 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2622 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 132)
introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 31 Inconclusive: 0 Failed: 8 Ignored: 5)
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/watchOS 32-bits - simulator/Debug: Failed
introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4): Failed
introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Failed
link sdk/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 85e649e into 6ce5f80

rolfbjarne

This looks good!

Just a few minor comments, and also the manual API you added (in AXHearingUtilities.cs) needs manual tests (in monotouch-test).

src/Accessibility/AXHearingUtilities.cs

rolfbjarne · 2021-06-22T07:45:35Z

src/Accessibility/AXHearingUtilities.cs

+        {
+            return NSArray.ArrayFromHandle<NSUuid> (AXMFiHearingDevicePairedUUIDs ());
+        }
+    }


It looks like you've used spaces for indentation - we use tabs.

This is still the case 😄

:( so strange... I'll check through everything again!

mandel-macaque · 2021-06-22T14:26:51Z

src/accessibility.cs

+
+	[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0)]
+	[Protocol]
+	[BaseType (typeof(NSObject))]


He means the attribute, since Model will create an instance.

src/accessibility.cs

mandel-macaque · 2021-06-22T14:35:19Z

src/accessibility.cs

+	}
+
+	[Watch (8,0), TV (15,0), Mac (12,0), iOS (15,0)]
+	[BaseType (typeof(NSObject))]


Do we need BaseType?

mandel-macaque · 2021-06-22T14:36:04Z

src/accessibility.cs

+		double UpperBound { get; set; }
+
+		[Export ("valueDescriptionProvider", ArgumentSemantic.Copy)]
+		Func<double, NSString> ValueDescriptionProvider { get; set; }


Maybe a delegate will be more helpful for the developers to understand what is going on.

If I'm understanding correctly, would that be something like this?

delegate double AXDataValue; delegate NSString AXDataValueDescription; [Export ("valueDescriptionProvider", ArgumentSemantic.Copy)] Func<AXDataValue, AXDataValueDescription> ValueDescriptionProvider { get; set; }

if not, what were you thinking? what am I missing?

No, more replacing Func with a delegate type. The later are self-documenting.

The more arguments the more important it becomes because Func<byte,short,int,long> has to meaning (without reading the docs). However a delegate type like delegate long Hash (byte b, short s, int i); describe what the function is expected to do.

Something like:

delegate AXDataValueDescription ValueDescriptionProviderHandler (AXDataValue dataValue);

To be honest, the headers do not help much.

vs-mobiletools-engineering-service2 · 2021-06-22T23:14:41Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 84 tests passed.

Failed tests

introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 34 Inconclusive: 0 Failed: 5 Ignored: 5)
monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge ebc3918 into 6898920

spouliot

pending requested tests and green / no related failures from bots

rolfbjarne · 2021-06-23T16:49:24Z

tests/monotouch-test/Accessibility/AXHearingUtilitiesTests.cs

+using Foundation;
+using Accessibility;
+using NUnit.Framework;
+using MonoTests.System.Net.Http;


Why do you need this using?

I don't :p poor copy/paste! removing

rolfbjarne · 2021-06-23T16:51:05Z

src/Accessibility/AXHearingUtilities.cs

+        {
+            return NSArray.ArrayFromHandle<NSUuid> (AXMFiHearingDevicePairedUUIDs ());
+        }
+    }


This is still the case 😄

vs-mobiletools-engineering-service2 · 2021-06-24T00:58:32Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 34 Inconclusive: 0 Failed: 5 Ignored: 5)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 0f5b82c into c4d5433

vs-mobiletools-engineering-service2 · 2021-06-24T18:41:57Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 34 Inconclusive: 0 Failed: 5 Ignored: 5)

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 6ee7efb into 4914136

dalexsoto

Ouch looks like you will need to fix your PR :(

rachelkang · 2021-06-29T21:23:42Z

@dalexsoto yes :/ there was a bad merge - @mandel-macaque is helping me fix it though 😅

vs-mobiletools-engineering-service2 · 2021-06-30T00:58:32Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1100.BigSur'
Merge f058918 into a64b030

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: Rachel Kang <rachelkang@microsoft.com>

rachelkang · 2021-06-30T15:30:41Z

intro and xtro are all green and happy :)

vs-mobiletools-engineering-service2 · 2021-06-30T19:39:28Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

link sdk/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)

Pipeline on Agent XAMBOT-1101.BigSur'
Merge eca53e5 into 801063d

tj-devel709 · 2021-07-06T16:13:16Z

The one failing test seems to be unrelated: https://github.com/xamarin/maccore/issues/2434

vs-mobiletools-engineering-service2 · 2021-07-06T21:35:12Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 20a1503 into 3b6f059

rachelkang added the note-highlight Worth calling out specifically in release notes label Jun 21, 2021

rachelkang added this to the xcode13.0 milestone Jun 21, 2021

rachelkang requested review from dalexsoto and spouliot June 21, 2021 22:36

spouliot suggested changes Jun 21, 2021

View reviewed changes

rolfbjarne requested changes Jun 22, 2021

View reviewed changes

mandel-macaque requested changes Jun 22, 2021

View reviewed changes

spouliot approved these changes Jun 23, 2021

View reviewed changes

mandel-macaque approved these changes Jun 23, 2021

View reviewed changes

mandel-macaque marked this pull request as ready for review June 23, 2021 02:36

rolfbjarne requested changes Jun 23, 2021

View reviewed changes

rolfbjarne approved these changes Jun 24, 2021

View reviewed changes

rachelkang requested a review from emaf as a code owner June 29, 2021 20:56

rachelkang removed the request for review from emaf June 29, 2021 20:59

dalexsoto requested changes Jun 29, 2021

View reviewed changes

[Accessibility] Update bindings for Xcode 13.0 beta 1

eca53e5

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: Rachel Kang <rachelkang@microsoft.com>

mandel-macaque force-pushed the xcode13.0-accessibility-b1 branch from f058918 to eca53e5 Compare June 30, 2021 14:58

Merge branch 'main' into xcode13.0-accessibility-b1

20a1503

rachelkang requested a review from dalexsoto July 7, 2021 17:16

mandel-macaque merged commit 9ca0942 into xamarin:main Jul 7, 2021

[Accessibility] Update bindings for Xcode 13.0 beta 1 #11998

[Accessibility] Update bindings for Xcode 13.0 beta 1 #11998

Conversation

rachelkang commented Jun 21, 2021

spouliot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Jun 22, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

rolfbjarne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rachelkang Jun 22, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Jun 22, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

spouliot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Jun 24, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Jun 24, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

dalexsoto left a comment

Choose a reason for hiding this comment

rachelkang commented Jun 29, 2021

vs-mobiletools-engineering-service2 commented Jun 30, 2021

✅ [PR Build] Tests passed on Build. ✅

API diff

API & Generator diff

GitHub pages

🎉 All 86 tests passed 🎉

rachelkang commented Jun 30, 2021 • edited Loading

vs-mobiletools-engineering-service2 commented Jun 30, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

tj-devel709 commented Jul 6, 2021

vs-mobiletools-engineering-service2 commented Jul 6, 2021

rachelkang Jun 22, 2021 •

edited

Loading

rachelkang commented Jun 30, 2021 •

edited

Loading