-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EventKit] Updates for Xcode13 Beta1 #12022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small fix, also a question regarding the attr.
@mandel-macaque I made an attempt with the delegate, let me know if it is sufficient haha |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving BUT the redundant attributes should be removed.
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 86 tests passed 🎉Pipeline on Agent XAMBOT-1101.BigSur' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small issue
Co-authored-by: Alex Soto <alex@alexsoto.me>
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
Unrelated test failure: https://github.com/xamarin/maccore/issues/2443 |
I was a little confused about this Frameworks MacCatalyst's backlog.
Possibly just an output
xamarin-macios/src/EventKit/EKEnums.cs
Line 180 in 2b7dc07
xamarin-macios/src/eventkit.cs
Line 204 in 9a0cd61
This group below belongs to EKAlarm which the web docs say support MacCatalyst 13.0 but the selectors themselves do not say they support MacCatalyst in the webdocs
These two are deprecated
Similar to the EKAlarm selectors, EKEventStore says that it supports MacCatalyst but initWithSources does not say it supports MacCatalyst