Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accounts] Update bindings for Xcode 13.0 beta 1 #12024

Merged
merged 8 commits into from
Jul 7, 2021
Merged

[Accounts] Update bindings for Xcode 13.0 beta 1 #12024

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4eae13e
[Accounts] Update bindings for Xcode 13.0 beta 1
rachelkang Jun 25, 2021
9bb53a3
Merge branch 'main' into xcode13.0-accounts-b1
rachelkang Jun 25, 2021
6eff085
Merge branch 'main' into xcode13.0-accounts-b1
rachelkang Jun 28, 2021
888544e
Merge branch 'main' into xcode13.0-accounts-b1
rachelkang Jun 28, 2021
adf56cc
Merge branch 'main' into xcode13.0-accounts-b1
mandel-macaque Jun 29, 2021
3a5740a
Merge branch 'main' into xcode13.0-accounts-b1
rachelkang Jun 30, 2021
d5a293a
Remove unnecessary availability tags
rachelkang Jun 30, 2021
fcf16bf
Merge branch 'main' into xcode13.0-accounts-b1
rachelkang Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/accounts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@

namespace Accounts {

[Introduced (PlatformName.iOS, 6, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Introduced (PlatformName.MacOSX, 10, 8, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduced is not needed here, it is given for granted because of the minimum version Xamarin.iOS supports

Suggested change
[Introduced (PlatformName.iOS, 6, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Introduced (PlatformName.MacOSX, 10, 8, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]

[BaseType (typeof (NSObject))]
interface ACAccount : NSSecureCoding {
[Export ("identifier", ArgumentSemantic.Weak)]
Expand Down Expand Up @@ -44,6 +48,10 @@ interface ACAccount : NSSecureCoding {
string UserFullName { get; }
}

[Introduced (PlatformName.iOS, 6, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Introduced (PlatformName.MacOSX, 10, 8, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Suggested change
[Introduced (PlatformName.iOS, 6, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Introduced (PlatformName.MacOSX, 10, 8, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]

[BaseType (typeof (NSObject))]
interface ACAccountCredential : NSSecureCoding {
[Export ("initWithOAuthToken:tokenSecret:")]
Expand All @@ -61,6 +69,10 @@ interface ACAccountCredential : NSSecureCoding {
delegate void ACAccountStoreRemoveCompletionHandler (bool success, NSError error);
delegate void ACRequestCompletionHandler (bool granted, NSError error);

[Introduced (PlatformName.iOS, 6, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Introduced (PlatformName.MacOSX, 10, 8, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Suggested change
[Introduced (PlatformName.iOS, 6, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Introduced (PlatformName.MacOSX, 10, 8, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]

[BaseType (typeof (NSObject))]
interface ACAccountStore {
[Export ("accounts", ArgumentSemantic.Weak)]
Expand Down Expand Up @@ -111,6 +123,10 @@ interface ACAccountStore {
void RemoveAccount (ACAccount account, ACAccountStoreRemoveCompletionHandler completionHandler);
}

[Introduced (PlatformName.iOS, 6, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Introduced (PlatformName.MacOSX, 10, 8, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Introduced (PlatformName.iOS, 6, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Introduced (PlatformName.MacOSX, 10, 8, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]

[BaseType (typeof (NSObject))]
interface ACAccountType : NSSecureCoding {
[Export ("accountTypeDescription")]
Expand Down
4 changes: 4 additions & 0 deletions src/social.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ interface SLRequest {
[Export ("requestForServiceType:requestMethod:URL:parameters:")]
SLRequest Create (NSString serviceType, SLRequestMethod requestMethod, NSUrl url, [NullAllowed] NSDictionary parameters);

[Introduced (PlatformName.iOS, 6, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Introduced (PlatformName.MacOSX, 10, 8, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

Suggested change
[Introduced (PlatformName.iOS, 6, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Introduced (PlatformName.MacOSX, 10, 8, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]

[Export ("account", ArgumentSemantic.Retain), NullAllowed]
ACAccount Account { get; set; }

Expand Down
7 changes: 6 additions & 1 deletion src/twitter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ namespace Twitter {
[Availability (Deprecated = Platform.iOS_6_0, Message = "Use the 'Social' framework.")]
[BaseType (typeof (NSObject))]
interface TWRequest {

[Introduced (PlatformName.iOS, 6, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Introduced (PlatformName.MacOSX, 10, 8, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed, the parent class is already deprecated.

Suggested change
[Introduced (PlatformName.iOS, 6, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.iOS, 15, 0, message: "Use the non-Apple SDK relating to your account type instead.")]
[Introduced (PlatformName.MacOSX, 10, 8, message: "Use the non-Apple SDK relating to your account type instead.")]
[Deprecated (PlatformName.MacOSX, 12, 0, message: "Use the non-Apple SDK relating to your account type instead.")]

[NullAllowed] // by default this property is null
[Export ("account")]
ACAccount Account { get; set; }
Expand Down Expand Up @@ -76,4 +81,4 @@ interface TWTweetComposeViewController {
bool RemoveAllUrls ();
}

}
}
4 changes: 0 additions & 4 deletions tests/xtro-sharpie/iOS-Accounts.todo
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +0,0 @@
!deprecated-attribute-missing! ACAccount missing a [Deprecated] attribute
!deprecated-attribute-missing! ACAccountCredential missing a [Deprecated] attribute
!deprecated-attribute-missing! ACAccountStore missing a [Deprecated] attribute
!deprecated-attribute-missing! ACAccountType missing a [Deprecated] attribute