Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutomaticAssessmentConfiguration] Updates for Xcode13 beta1 #12070

Conversation

tj-devel709
Copy link
Contributor

No description provided.

@tj-devel709 tj-devel709 added the note-highlight Worth calling out specifically in release notes label Jul 1, 2021
@tj-devel709 tj-devel709 added this to the xcode13.0 milestone Jul 1, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1104.BigSur'
Merge b36a566 into 20dc67f


[NoiOS, Mac (12,0), MacCatalyst (15,0)]
[Export ("assessmentSessionDidUpdate:")]
void DidUpdate (AEAssessmentSession session);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No iOS but MacCatalyst? That is weird.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah.. that is interesting

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the docs, is is correct, and that is why I approved, it is just funny that Catalyst was meant to be iOS apps that run on Mac, yet they do things like this. 🍎

Copy link
Contributor

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering - what does this part of the diff signify? How should it be addressed? (from the wiki)

-API_AVAILABLE(ios(13.4), macos(10.15.4), macCatalyst(14))
-extern NSErrorDomain const AEAssessmentErrorDomain;
+AE_VISIBLE NSErrorDomain const AEAssessmentErrorDomain API_AVAILABLE(ios(13.4), macos(10.15.4), macCatalyst(14));

@tj-devel709
Copy link
Contributor Author

I'm just wondering - what does this part of the diff signify? How should it be addressed? (from the wiki)

-API_AVAILABLE(ios(13.4), macos(10.15.4), macCatalyst(14))
-extern NSErrorDomain const AEAssessmentErrorDomain;
+AE_VISIBLE NSErrorDomain const AEAssessmentErrorDomain API_AVAILABLE(ios(13.4), macos(10.15.4), macCatalyst(14));

That's a good question. It just looked like noise to me and did not show up on the todos so I just ignored it. Perhaps @mandel-macaque has the answer?

@mandel-macaque
Copy link
Member

I'm just wondering - what does this part of the diff signify? How should it be addressed? (from the wiki)

-API_AVAILABLE(ios(13.4), macos(10.15.4), macCatalyst(14))
-extern NSErrorDomain const AEAssessmentErrorDomain;
+AE_VISIBLE NSErrorDomain const AEAssessmentErrorDomain API_AVAILABLE(ios(13.4), macos(10.15.4), macCatalyst(14));
That's a good question. It just looked like noise to me and did not show up on the todos so I just ignored it. Perhaps @mandel-macaque has the answer?

That is noise, someone changing a MACRO, I don't know why they change the macros EVERY YEAR. It is noise.

@tj-devel709 tj-devel709 merged commit 956828f into xamarin:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants