[CHIP] Add support fox Xcode 13 beta 3. #12143

mandel-macaque · 2021-07-19T21:54:28Z

No description provided.

vs-mobiletools-engineering-service2 · 2021-07-20T01:43:04Z

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 86 tests passed 🎉

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 1675dd5 into e968a93

spouliot · 2021-07-20T12:30:58Z

src/chip.cs

+
+		[Async (ResultTypeName = "ChipReadAttributeResult")]
+		[Export ("opCSRRequest:responseHandler:")]
+		void OpCSRRequest (NSData cSRNonce, ChipResponseHandler responseHandler);


OpCsrRequest -> Csr -> TLA

parameter name should be csrNonce too

spouliot · 2021-07-20T12:31:57Z

src/chip.cs

+
+		[Async (ResultTypeName = "ChipReadAttributeResult")]
+		[Export ("login:setupPIN:responseHandler:")]
+		void Login (string tempAccountIdentifier, string setupPIN, ChipResponseHandler  responseHandler);


-> setupPin

spouliot · 2021-07-20T14:21:45Z

src/chip.cs

@@ -1140,7 +1140,7 @@ interface ChipOperationalCredentials

 		[Async (ResultTypeName = "ChipReadAttributeResult")]
 		[Export ("opCSRRequest:responseHandler:")]
-		void OpCSRRequest (NSData cSRNonce, ChipResponseHandler responseHandler);
+		void OpCsRrequest (NSData csrNonce, ChipResponseHandler responseHandler);


wrong r
OpCsRrequest -> OpCsrRequest

rachelkang

The diff shows that the NSError param in the CHIPDevicePairingDelegate methods onPairingComplete, onPairingDeleted, and onAddressUpdated are now nullable. Should there be a [NullAllowed] attribute added to those?

Similarly, should CHIPGetKeyValue be decorated with a [NullAllowed] attribute as well?

rachelkang · 2021-07-20T14:57:44Z

src/chip.cs

+
+		[Async (ResultTypeName = "ChipReadAttributeResult")]
+		[Export ("configureAttributeMeasuredValueWithMinInterval:maxInterval:change:responseHandler:")]
+		void ConfigureAttributeMeasuredValueWithMinInterval (ushort minInterval, ushort maxInterval, ushort change, ChipResponseHandler responseHandler);


ConfigureAttributeMeasuredValueWithMinInterval --> ConfigureAttributeMeasuredValue

rachelkang · 2021-07-20T15:00:18Z

src/chip.cs

+
+		[Async (ResultTypeName = "ChipReadAttributeResult")]
+		[Export ("windowCoveringUpOpen:")]
+		void WindowCoveringUpOpen (ChipResponseHandler responseHandler);


I think you can (maybe?) get rid of the WindowCovering prefix on all of the above

src/chip.cs

Why are pirates call pirates? Because the RRRR!

spouliot

nice catches @rachelkang !

vs-mobiletools-engineering-service2 · 2021-07-20T18:27:55Z

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge 72c1e08 into 09f911b

tj-devel709 · 2021-07-20T22:04:14Z

src/chip.cs

+		Invalid = 3,
+	}
+
+


small: extra newline

src/chip.cs

vs-mobiletools-engineering-service2 · 2021-07-21T00:55:01Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 85 tests passed.

Failed tests

monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2494 Inconclusive: 35 Failed: 1 Ignored: 134)

Pipeline on Agent XAMBOT-1098.BigSur'
Merge a06f5c2 into eea8142

src/chip.cs

Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>

That API was removed in beta 3. https://github.com/xamarin/xamarin-macios/wiki/CHIP-iOS-xcode13.0-beta3 but this was missed by xamarin#12143

rolfbjarne · 2021-07-22T08:43:29Z

/sudo backport release/6.0.1xx-preview7

vs-mobiletools-engineering-service2 · 2021-07-22T08:43:48Z

Backport Job to branch release/6.0.1xx-preview7 Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2021-07-22T08:44:58Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5007513 for more details.

That API was removed in beta 3. https://github.com/xamarin/xamarin-macios/wiki/CHIP-iOS-xcode13.0-beta3 but this was missed by xamarin#12143

That API was removed in beta 3. https://github.com/xamarin/xamarin-macios/wiki/CHIP-iOS-xcode13.0-beta3 but this was missed by #12143

…12169) * [CHIP] Add support fox Xcode 13 beta 3. * Address reviews. * Address reviews. * Fix typo, wrong R. Why are pirates call pirates? Because the RRRR! * Apply suggestions from code review Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> * [chip] Remove API to fix intro on macOS 12 beta 3 That API was removed in beta 3. https://github.com/xamarin/xamarin-macios/wiki/CHIP-iOS-xcode13.0-beta3 but this was missed by #12143 Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: Sebastien Pouliot <sebastien.pouliot@microsoft.com>

[CHIP] Add support fox Xcode 13 beta 3.

1675dd5

mandel-macaque added the note-highlight Worth calling out specifically in release notes label Jul 19, 2021

mandel-macaque requested a review from spouliot as a code owner July 19, 2021 21:54

rolfbjarne approved these changes Jul 20, 2021

View reviewed changes

spouliot suggested changes Jul 20, 2021

View reviewed changes

Address reviews.

bad7f4e

spouliot reviewed Jul 20, 2021

View reviewed changes

rachelkang reviewed Jul 20, 2021

View reviewed changes

Address reviews.

70747ae

mandel-macaque commented Jul 20, 2021

View reviewed changes

src/chip.cs Outdated Show resolved Hide resolved

Fix typo, wrong R.

72c1e08

Why are pirates call pirates? Because the RRRR!

spouliot approved these changes Jul 20, 2021

View reviewed changes

Merge branch 'main' into chip-xcode13-beta3

a06f5c2

tj-devel709 reviewed Jul 20, 2021

View reviewed changes

src/chip.cs Outdated

Invalid = 3,

}

Copy link

Contributor

tj-devel709 Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small: extra newline

tj-devel709 reviewed Jul 20, 2021

View reviewed changes

src/chip.cs Outdated Show resolved Hide resolved

tj-devel709 reviewed Jul 20, 2021

View reviewed changes

src/chip.cs Outdated Show resolved Hide resolved

tj-devel709 approved these changes Jul 20, 2021

View reviewed changes

mandel-macaque commented Jul 21, 2021

View reviewed changes

src/chip.cs Outdated Show resolved Hide resolved

Apply suggestions from code review

f38c961

Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>

mandel-macaque merged commit adc002b into xamarin:main Jul 21, 2021

spouliot mentioned this pull request Jul 21, 2021

[chip] Remove API to fix intro on macOS 12 beta 3 #12166

Merged

vs-mobiletools-engineering-service2 mentioned this pull request Jul 22, 2021

[release/6.0.1xx-preview7] [CHIP] Add support fox Xcode 13 beta 3. #12169

Merged

spouliot added a commit that referenced this pull request Jul 22, 2021

[chip] Remove API to fix intro on macOS 12 beta 3 (#12166)

23d3fa5

That API was removed in beta 3. https://github.com/xamarin/xamarin-macios/wiki/CHIP-iOS-xcode13.0-beta3 but this was missed by #12143

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CHIP] Add support fox Xcode 13 beta 3. #12143

[CHIP] Add support fox Xcode 13 beta 3. #12143

mandel-macaque commented Jul 19, 2021

vs-mobiletools-engineering-service2 commented Jul 20, 2021

spouliot Jul 20, 2021

spouliot Jul 20, 2021

spouliot Jul 20, 2021

spouliot Jul 20, 2021

rachelkang left a comment

rachelkang Jul 20, 2021

rachelkang Jul 20, 2021

spouliot left a comment

vs-mobiletools-engineering-service2 commented Jul 20, 2021

tj-devel709 Jul 20, 2021

vs-mobiletools-engineering-service2 commented Jul 21, 2021

Failed tests

rolfbjarne commented Jul 22, 2021

vs-mobiletools-engineering-service2 commented Jul 22, 2021

vs-mobiletools-engineering-service2 commented Jul 22, 2021

[CHIP] Add support fox Xcode 13 beta 3. #12143

[CHIP] Add support fox Xcode 13 beta 3. #12143

Conversation

mandel-macaque commented Jul 19, 2021

vs-mobiletools-engineering-service2 commented Jul 20, 2021

✅ [PR Build] Tests passed on Build. ✅

API diff

API & Generator diff

GitHub pages

🎉 All 86 tests passed 🎉

spouliot Jul 20, 2021

Choose a reason for hiding this comment

spouliot Jul 20, 2021

Choose a reason for hiding this comment

spouliot Jul 20, 2021

Choose a reason for hiding this comment

spouliot Jul 20, 2021

Choose a reason for hiding this comment

rachelkang left a comment

Choose a reason for hiding this comment

rachelkang Jul 20, 2021

Choose a reason for hiding this comment

rachelkang Jul 20, 2021

Choose a reason for hiding this comment

spouliot left a comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Jul 20, 2021

🔥 Tests failed catastrophically on Build (no summary found). 🔥

tj-devel709 Jul 20, 2021

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Jul 21, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

rolfbjarne commented Jul 22, 2021

vs-mobiletools-engineering-service2 commented Jul 22, 2021

vs-mobiletools-engineering-service2 commented Jul 22, 2021