[ImageIO] Add support for Xcode 13 beta 3. #12145
Conversation
mandel-macaque
added
the
note-highlight
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1102.BigSur' |
There was a problem hiding this comment.
So I added 15, I wonder if adding 19 and wait for the next beta is the correct way to go.
No need. Apple can either:
- correct this (to 15) before release (might be after Xcode 13.0 is shipped)
- that would require another commit (or two, if after 13.0)
- remove it
- that would require another commit
Using 15,0 means you're likely avoiding another commit in the future, one that could be forgotten (if done after Xcode 13 is stable). Adding 19,0 would also require incorrect changes to the version (Xcode/OS) mapping code used for testing.
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 85 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
|
/sudo backport release/6.0.1xx-preview7 |
|
Backport Job to branch release/6.0.1xx-preview7 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5002434 for more details. |
@spouliot the headers say iOS 19 which makes no sense (although is good to know apple is thinking that far ahead ;) So I added 15, I wonder if adding 19 and wait for the next beta is the correct way to go.