Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StoreKit] Update bindings for Xcode 13.0 beta 1 #12152

Merged
merged 4 commits into from
Jul 23, 2021

Conversation

rachelkang
Copy link
Contributor

No beta 2 or beta 3 diffs

@rachelkang rachelkang added the note-highlight Worth calling out specifically in release notes label Jul 20, 2021
@rachelkang rachelkang added this to the xcode13.0 milestone Jul 20, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Tests failed catastrophically on Build (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent
Merge bd4c627 into 09f911b

src/storekit.cs Outdated
@@ -659,6 +659,10 @@ interface SKStoreProductParameterKey
[MacCatalyst (14,0)]
[Field ("SKStoreProductParameterAdNetworkVersion")]
NSString AdNetworkVersion { get; }

[Mac (12, 0), iOS (15, 0), MacCatalyst (15, 0)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that needs a [NoTV] if it's not available on tvOS
otherwise it will default to the minimum value (9.0) since it will fallback to the type definition (which is supported on tvOS)

There's no need for a [NoWatch] here since it's already present at the type-level

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

header files don't say anything about TV, but the web docs indicate availability, so I'm adding it in!

src/storekit.cs Outdated Show resolved Hide resolved
src/storekit.cs Outdated Show resolved Hide resolved
src/storekit.cs Outdated Show resolved Hide resolved
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 after the changes requested by @spouliot

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 84 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2494 Inconclusive: 35 Failed: 1 Ignored: 134)
  • introspection/tvOS - simulator/Debug (tvOS 11.4): Failed

Pipeline on Agent XAMBOT-1101.BigSur'
Merge eec8246 into eea8142

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 89 tests passed 🎉

Pipeline on Agent XAMBOT-1104.BigSur'
Merge e40dc09 into 2af23db

@rachelkang rachelkang merged commit 24acd2d into xamarin:main Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants