-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[StoreKit] Update bindings for Xcode 13.0 beta 1 #12152
Conversation
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
src/storekit.cs
Outdated
@@ -659,6 +659,10 @@ interface SKStoreProductParameterKey | |||
[MacCatalyst (14,0)] | |||
[Field ("SKStoreProductParameterAdNetworkVersion")] | |||
NSString AdNetworkVersion { get; } | |||
|
|||
[Mac (12, 0), iOS (15, 0), MacCatalyst (15, 0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that needs a [NoTV]
if it's not available on tvOS
otherwise it will default to the minimum value (9.0) since it will fallback to the type definition (which is supported on tvOS)
There's no need for a [NoWatch]
here since it's already present at the type-level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
header files don't say anything about TV, but the web docs indicate availability, so I'm adding it in!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 after the changes requested by @spouliot
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 84 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 89 tests passed 🎉Pipeline on Agent XAMBOT-1104.BigSur' |
No beta 2 or beta 3 diffs