Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenGL] Add support for xcode 13 beta4. #12394

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

mandel-macaque
Copy link
Member

The ignore overlap between macOS and Catalyst was done via:

# sort todo and ignore
sort -o macOS-OpenGL[ES].sorted macOS-OpenGL[ES].ignore 
sort -o MacCatalyst-OpenGL[ES].sorted MacCatalyst-OpenGL[ES].todo
# compare sorted files
comm -1 -2  MacCatalyst-SystemConfiguration.sorted macOS-OpenGL[ES].sorted  >> MacCatalyst-OpenGL[ES].ignore 

There are 9 selectors not ignored in macOS

!missing-pinvoke! CGLChoosePixelFormat is not bound
!missing-pinvoke! CGLGetCurrentContext is not bound
!missing-pinvoke! CGLLockContext is not bound
!missing-pinvoke! CGLReleaseContext is not bound
!missing-pinvoke! CGLReleasePixelFormat is not bound
!missing-pinvoke! CGLRetainContext is not bound
!missing-pinvoke! CGLRetainPixelFormat is not bound
!missing-pinvoke! CGLSetCurrentContext is not bound
!missing-pinvoke! CGLUnlockContext is not bound

But these are ignored because they are deprecated in mac telling users to use metal.

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Aug 10, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 91 tests passed 🎉

Pipeline on Agent XAMBOT-1100.BigSur'
Merge 932641b into ae77aed

@mandel-macaque mandel-macaque merged commit c5573db into xamarin:main Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants