[MailKit] Introducing in Xcode13 Beta 5 #12405
Conversation
tj-devel709
added
the
note-highlight
| NSDate DateReceived { get; } | ||
|
|
||
| [NullAllowed, Export ("headers", ArgumentSemantic.Copy)] | ||
| NSDictionary<NSString, NSArray<NSString>> Headers { get; } |
There was a problem hiding this comment.
Can this be a smart dictionary ?
There was a problem hiding this comment.
Sorry, what do you mean by smart dictionary?
There was a problem hiding this comment.
There was a problem hiding this comment.
It might be the case it can't since headers can be anything in the mail protocol, so lets ignore it for now
| [Advice ("'MEMessageActionDecision' is not available in UIKit on macOS.")] | ||
| [BaseType (typeof (NSObject))] | ||
| [DisableDefaultCtor] | ||
| interface MEMessageActionDecision : NSSecureCoding |
There was a problem hiding this comment.
Static class? All methods/properties are static and we have no contractor.
There was a problem hiding this comment.
I can make it a static class!
Question though, if they introduce a constructor later though and non-static methods, would changing it back be a breaking change or is that very unlikely to happen?
There was a problem hiding this comment.
This can't be a static class heh
There was a problem hiding this comment.
And it should not, i'm wrong we get it from https://developer.apple.com/documentation/mailkit/memessageactionhandler/3783568-decideactionformessage?changes=_3&language=objc
So we need to be able to instantiate the class.
There was a problem hiding this comment.
When I made the interface static, I got these errors in the build: https://gist.github.com/tj-devel709/a4500a4835c99831d0d2f7883f92fe5d
There was a problem hiding this comment.
Oops, sorry didn't refresh before I posted that ^
tools/common/Frameworks.cs
Outdated
| @@ -264,6 +264,7 @@ public Framework Find (string framework) | |||
| { "Chip", "CHIP", 12, 0 }, | |||
| { "MetricKit", 12, 0 }, | |||
| { "Phase", "PHASE", 12, 0 }, | |||
| { "MailKit", "MailKit", 12, 0 }, | |||
There was a problem hiding this comment.
Alphabetical order please.
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 93 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
|
Beta5 changes need to be added here |
tj-devel709
changed the title
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 95 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 100 tests passed.Failed tests
Pipeline on Agent XAMBOT-1101.BigSur' |
|
Failing tests are unrelated networking issues! |
I have a few comments/questions listed down below that I would like help with!