Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVKit] Add support for xcode 12 beta 5. #12551

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

mandel-macaque
Copy link
Member

No description provided.

@mandel-macaque mandel-macaque added the note-highlight Worth calling out specifically in release notes label Aug 25, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

23 tests failed, 85 tests passed.

Failed tests

  • introspection/Mac Modern/Debug: BuildFailure
  • framework-test/Mac Modern/Debug: BuildFailure
  • framework-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • framework-test/tvOS - simulator/Debug: BuildFailure
  • framework-test/watchOS 32-bits - simulator/Debug: BuildFailure
  • xcframework-test/Mac Modern/Debug: BuildFailure
  • xcframework-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • xcframework-test/tvOS - simulator/Debug: BuildFailure
  • xcframework-test/watchOS 32-bits - simulator/Debug: BuildFailure
  • link all/Mac Catalyst/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)
  • monotouch-test/iOS Unified 64-bits - simulator/Debug: BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): BuildFailure
  • monotouch-test/tvOS - simulator/Debug: BuildFailure
  • monotouch-test/tvOS - simulator/Debug (LinkSdk): BuildFailure
  • monotouch-test/tvOS - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/tvOS - simulator/Release (all optimizations): BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Debug: BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): BuildFailure
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): BuildFailure
  • MSBuild tests/Integration: Failed (Execution failed with exit code 50)

Pipeline on Agent XAMBOT-1099.BigSur'
Merge b9452e2 into f0373ee

src/avkit.cs Outdated
@@ -497,6 +535,15 @@ interface AVPlayerView {
[Mac (10,15)]
[Export ("showsTimecodes")]
bool ShowsTimecodes { get; set; }

[Mac (12,0), NoiOS, NoTV, NoMacCatalyst]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NoiOS, NoTV, NoMacCatalyst] are already present at the type-level

src/avkit.cs Outdated
[Protocolize]
AVPlayerViewDelegate Delegate { get; set; }

[Mac (12,0), NoiOS, NoTV, NoMacCatalyst]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NoiOS, NoTV, NoMacCatalyst] are already present at the type-level

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 107 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2638 Passed: 2490 Inconclusive: 35 Failed: 1 Ignored: 147)

Pipeline on Agent XAMBOT-1107.BigSur'
Merge c32f048 into 58ae71b

@mandel-macaque
Copy link
Member Author

Unrelated failures.

@mandel-macaque mandel-macaque merged commit 53988e1 into xamarin:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants