[CoreImage] Update Xcode 13.0 bindings betas 1 and 3 #12601

rachelkang · 2021-08-31T18:40:40Z

No updates for betas 2, 4, 5

Unclear of Catalyst availability for APIs left in todo/backlog - xtro indicates availability, but I haven't found anything in header files or web docs

rachelkang · 2021-08-31T18:42:36Z

src/coreimage.cs

+		// [iOS (15,0), Mac (12,0), MacCatalyst (15,0), TV (15,0)]
+		// [Wrap ("GetHeif10Representation (This, image, colorSpace, options.GetDictionary ()!, out error)")]
+		// [return: NullAllowed]
+		// NSData GetHeif10Representation (CIImage image, CGColorSpace colorSpace, NSDictionary<NSString, NSObject> options, [NullAllowed] out NSError errorPtr);


do I need to comment in these wrappers? haven't hit any issues yet, but similar existing methods (see below) have them

Why are they commented out?

I added them in as comments, because I wanted to ask about them / thought I might need to add them

they should be uncommented
the wrapper let developer uses the CIImageRepresentationOptions strongly-typed class instead of the weakly-typed NSDictionary

spouliot

Looks good. Minor changes

I'll be trying it locally to reproduce the intro error!

src/coreimage.cs

tests/xtro-sharpie/common-CoreImage.ignore

mandel-macaque · 2021-08-31T19:28:29Z

src/coreimage.cs

+		// [iOS (15,0), Mac (12,0), MacCatalyst (15,0), TV (15,0)]
+		// [Wrap ("GetHeif10Representation (This, image, colorSpace, options.GetDictionary ()!, out error)")]
+		// [return: NullAllowed]
+		// NSData GetHeif10Representation (CIImage image, CGColorSpace colorSpace, NSDictionary<NSString, NSObject> options, [NullAllowed] out NSError errorPtr);


Why are they commented out?

src/coreimage.cs

vs-mobiletools-engineering-service2 · 2021-08-31T22:35:20Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

8 tests failed, 102 tests passed.

Failed tests

introspection/Mac Modern/Debug: Failed (Test run failed.
Tests run: 37 Passed: 35 Inconclusive: 0 Failed: 1 Ignored: 1)
introspection/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 37 Passed: 33 Inconclusive: 0 Failed: 1 Ignored: 3)
introspection/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 44 Passed: 40 Inconclusive: 0 Failed: 1 Ignored: 3)
introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 39 Inconclusive: 0 Failed: 1 Ignored: 4)
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4): Failed
introspection/tvOS - simulator/Debug (tvOS 11.4): Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 47e5e4a into 066d5b5

vs-mobiletools-engineering-service2 · 2021-09-01T02:53:03Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

10 tests failed, 100 tests passed.

Failed tests

introspection/Mac Modern/Debug: Failed (Test run failed.
Tests run: 37 Passed: 35 Inconclusive: 0 Failed: 1 Ignored: 1)
introspection/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 37 Passed: 33 Inconclusive: 0 Failed: 1 Ignored: 3)
introspection/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 44 Passed: 40 Inconclusive: 0 Failed: 1 Ignored: 3)
introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 39 Inconclusive: 0 Failed: 1 Ignored: 4)
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4): Failed
introspection/tvOS - simulator/Debug (tvOS 11.4): Failed
dont link/Mac Catalyst/Debug [dotnet]: Failed (Test run crashed (exit code: 134).
Tests run: 11 Passed: 6 Inconclusive: 0 Failed: 0 Ignored: 5)
xcframework-test/Mac Catalyst/Debug: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge 26d9ae8 into cda8808

spouliot · 2021-09-01T15:19:39Z

src/coreimage.cs

+		[Static]
+		[Export ("filterWithImageURL:")]
+		[return: NullAllowed]
+		CIRawFilter Filter (NSUrl url);


this method will not filter the url, it will create a filter from the url
rename if to Create

spouliot · 2021-09-01T15:19:47Z

src/coreimage.cs

+		[Static]
+		[Export ("filterWithImageData:identifierHint:")]
+		[return: NullAllowed]
+		CIRawFilter Filter (NSData data, [NullAllowed] string identifierHint);


spouliot · 2021-09-01T15:19:55Z

src/coreimage.cs

+		[Static]
+		[Export ("filterWithCVPixelBuffer:properties:")]
+		[return: NullAllowed]
+		CIRawFilter Filter (CVPixelBuffer buffer, NSDictionary properties);


vs-mobiletools-engineering-service2 · 2021-09-01T18:50:03Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

8 tests failed, 102 tests passed.

Failed tests

introspection/Mac Modern/Debug: Failed (Test run failed.
Tests run: 37 Passed: 35 Inconclusive: 0 Failed: 1 Ignored: 1)
introspection/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
Tests run: 37 Passed: 33 Inconclusive: 0 Failed: 1 Ignored: 3)
introspection/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 44 Passed: 40 Inconclusive: 0 Failed: 1 Ignored: 3)
introspection/Mac Catalyst/Debug: Failed (Tests run: 44 Passed: 39 Inconclusive: 0 Failed: 1 Ignored: 4)
introspection/iOS Unified 64-bits - simulator/Debug: Failed
introspection/tvOS - simulator/Debug: Failed
introspection/iOS Unified 64-bits - simulator/Debug (iOS 11.4): Failed
introspection/tvOS - simulator/Debug (tvOS 11.4): Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge fc03174 into 3fc6b06

spouliot

make sure the comments for CIRawFilter are part of the committed message (when you merge), otherwise they'll be hard to find

vs-mobiletools-engineering-service2 · 2021-09-01T22:55:37Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 109 tests passed.

Failed tests

monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge b3869af into 14b77dc

tj-devel709 · 2021-09-02T18:52:12Z

src/coreimage.cs

@@ -430,7 +430,7 @@ interface CIContext_ImageRepresentation {
 		[Wrap ("GetJpegRepresentation (This, image, colorSpace, options.GetDictionary ()!)")]
 		[return: NullAllowed]
 		NSData GetJpegRepresentation (CIImage image, CGColorSpace colorSpace, CIImageRepresentationOptions options);
-
+ 


Not sure if this is an extra space with this newline or if it is just a newline!

tj-devel709 · 2021-09-02T18:55:42Z

src/coreimage.cs

 	[TV (10,0)]
 	[Static]
 	[Internal]
 	interface CIRawFilterKeys {
+


nit: extra newline

tj-devel709

Left two small whitespace suggestions!

rolfbjarne · 2021-09-06T16:09:10Z

This looks great!

vs-mobiletools-engineering-service2 · 2021-09-08T20:51:29Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

4 tests failed, 100 tests passed.

Failed tests

introspection/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)
dont link/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)
link sdk/tvOS - simulator/Debug: Failed
link sdk/tvOS - simulator/Release: Failed

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 017862e into c2fda6e

vs-mobiletools-engineering-service2 · 2021-09-09T02:42:55Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

4 tests failed, 100 tests passed.

Failed tests

link sdk/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)
link sdk/tvOS - simulator/Debug: Failed
link sdk/tvOS - simulator/Release: Failed
Xtro/Mac: BuildFailure

Pipeline on Agent XAMBOT-1102.BigSur'
Merge f58039f into 97e2e00

vs-mobiletools-engineering-service2 · 2021-09-09T23:33:27Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 102 tests passed.

Failed tests

link sdk/tvOS - simulator/Debug: Failed
link sdk/tvOS - simulator/Release: Failed

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 19dcf3f into 55e8c60

from Sebastien: "most filters are key-based natively (not-NSObject subclasses)) and we expose them as C# _user-type_ CIFilter-subclasses in recent years _most_ filters have also been exposed natively as protocols (not classes), we expose them as `*Protocol` interface types `CIRAWFilter` is a special case, it's a native `CIFilter` subclass so we're not using [CoreImageFilter] and [CoreImageFilterProperty] attributes to define it which also means we cannot use the "extra" tests to validate the filter properties. So we skip it here. Do not fear it's still tested, like any _normal_, NSObject subclass we have bound :-)"

vs-mobiletools-engineering-service2 · 2021-09-11T02:21:10Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 101 tests passed.

Failed tests

Xtro/Mac: BuildFailure
link sdk/tvOS - simulator/Debug: Failed
link sdk/tvOS - simulator/Release: Failed

Pipeline on Agent XAMBOT-1106.BigSur'
Merge fba8fe6 into aadd532

rachelkang · 2021-09-13T18:43:51Z

xtro and intro tests are all passing beautifully

vs-mobiletools-engineering-service2 · 2021-09-13T23:00:15Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 101 tests passed.

Failed tests

dont link/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)
link sdk/tvOS - simulator/Debug: Failed
link sdk/tvOS - simulator/Release: Failed

Pipeline on Agent XAMBOT-1104.BigSur'
Merge f1e8f01 into 71d2edb

spouliot

don't forget the CIRAWFilter comments in your commit message!

rachelkang · 2021-09-15T17:56:03Z

failing tests not related
https://github.com/xamarin/maccore/issues/2414
https://github.com/xamarin/maccore/issues/2379

rachelkang added the note-highlight Worth calling out specifically in release notes label Aug 31, 2021

rachelkang added this to the xcode13.0 milestone Aug 31, 2021

rachelkang requested review from dalexsoto and spouliot August 31, 2021 18:40

rachelkang commented Aug 31, 2021

View reviewed changes

spouliot suggested changes Aug 31, 2021

View reviewed changes

src/coreimage.cs Outdated Show resolved Hide resolved

src/coreimage.cs Outdated Show resolved Hide resolved

src/coreimage.cs Outdated Show resolved Hide resolved

src/coreimage.cs Outdated Show resolved Hide resolved

tests/xtro-sharpie/common-CoreImage.ignore Show resolved Hide resolved

mandel-macaque requested changes Aug 31, 2021

View reviewed changes

spouliot suggested changes Sep 1, 2021

View reviewed changes

spouliot approved these changes Sep 1, 2021

View reviewed changes

tj-devel709 reviewed Sep 2, 2021

View reviewed changes

tj-devel709 approved these changes Sep 2, 2021

View reviewed changes

rolfbjarne approved these changes Sep 6, 2021

View reviewed changes

rachelkang requested review from chamons and emaf as code owners September 9, 2021 16:57

emaf approved these changes Sep 9, 2021

View reviewed changes

rachelkang added 3 commits September 10, 2021 14:09

[CoreImage] Update bindings for Xcode 13.0 beta 1 and 3

08cc749

Add missing changes

66a2826

rachelkang force-pushed the xcode13.0-coreimage-b1-b3 branch from 19dcf3f to 66a2826 Compare September 10, 2021 21:59

Merge branch 'main' into xcode13.0-coreimage-b1-b3

fba8fe6

rachelkang requested a review from mandel-macaque September 10, 2021 22:01

rachelkang requested a review from spouliot September 10, 2021 22:01

rachelkang added 2 commits September 13, 2021 12:29

Merge branch 'main' into xcode13.0-coreimage-b1-b3

040db10

Fix xtro failures by removing catalyst todo and ignore files

f1e8f01

spouliot approved these changes Sep 14, 2021

View reviewed changes

rachelkang merged commit b9cde5e into xamarin:main Sep 15, 2021

[CoreImage] Update Xcode 13.0 bindings betas 1 and 3 #12601

[CoreImage] Update Xcode 13.0 bindings betas 1 and 3 #12601

Conversation

rachelkang commented Aug 31, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

spouliot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Aug 31, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Sep 1, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Sep 1, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

spouliot left a comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Sep 1, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tj-devel709 left a comment

Choose a reason for hiding this comment

rolfbjarne commented Sep 6, 2021

vs-mobiletools-engineering-service2 commented Sep 8, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Sep 9, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Sep 9, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

vs-mobiletools-engineering-service2 commented Sep 11, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

rachelkang commented Sep 13, 2021

vs-mobiletools-engineering-service2 commented Sep 13, 2021

❌ [PR Build] Tests failed on Build ❌

rachelkang commented Aug 31, 2021 •

edited

Loading