[Intents] Update bindings for Xcode 13.0 betas 1 through 5 #12771

rachelkang · 2021-09-17T21:11:55Z

build and intro and xtro and I are all happy :)

vs-mobiletools-engineering-service2 · 2021-09-18T01:23:52Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

5 tests failed, 97 tests passed.

Failed tests

introspection/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)
monotouch-test/watchOS 32-bits - simulator/Debug: BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): BuildFailure
monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): BuildFailure

Pipeline on Agent XAMBOT-1100.BigSur'
Merge d1ce9ff into d94a0f5

rolfbjarne · 2021-09-20T06:13:36Z

src/Intents/INPerson.cs

+	[SupportedOSPlatform ("macos12.0")]
+#endif //!NET
+        public enum INPersonType {


The indentation is off here, and it looks like the indentation is spaces too (when it should be tabs).

ahh thanks for catching!

src/intents.cs

rolfbjarne · 2021-09-20T06:31:59Z

src/intents.cs

 	[iOS (10, 0)]
-	[Watch (3, 2)]
-	[NoTV, Mac (11,0)]
+	[NoWatch] // it says it's now NoWatch, but not deprecated? (there was previous watch availability)


This is a breaking change, if the type was already present in an earlier version of Xamarin.iOS, we can't remove it now (we have to mark it as deprecated instead).

makes sense, thanks!

src/intents.cs

rolfbjarne · 2021-09-20T13:49:12Z

src/Intents/INPerson.cs

+	{
+
+#if !NET
+	[Introduced (PlatformName.iOS, 15,0)]


The indentation is still off for all the attributes in this file (looks like they should be indented one more level).

tj-devel709 · 2021-09-20T14:16:40Z

src/Intents/INPerson.cs

+#else
+	[SupportedOSPlatform ("ios15.0")]
+	[SupportedOSPlatform ("macos12.0")]
+	#endif //!NET


Looks like extra indentation here

tj-devel709 · 2021-09-20T14:25:23Z

src/intents.cs

-
-		[Watch (7,0), NoTV, NoMac, iOS (14,0)]
+	interface INStartCallIntent : UNNotificationContentProviding {
+


extra whitespace

tj-devel709 · 2021-09-20T14:27:54Z

I know Sebastien explained a little to me why, but I think I am still a little confused about something. It makes sense to me to turn a 'NoMac' to a 'Mac 12,0' but why are we changing the already available Mac attributes (ie. Mac 11,3) to 'Mac 12,0' inside src/intents.cs?

rachelkang · 2021-09-20T15:44:32Z

I know Sebastien explained a little to me why, but I think I am still a little confused about something. It makes sense to me to turn a 'NoMac' to a 'Mac 12,0' but why are we changing the already available Mac attributes (ie. Mac 11,3) to 'Mac 12,0' inside src/intents.cs?

@tj-devel709 yeah, it's confusing! there are slightly different justifications based on the scenario, but for the most part, what happened was that the interface was originally NoMac and some properties inside of them appeared to have some earlier Mac availability. But if I understood Sebastien correctly, this was incorrect to begin with because "it should not exist in Xamarin.Mac if the type has [NoMac]"

tj-devel709 · 2021-09-20T16:39:40Z

Ah I see now! Thanks for clearing that up for me, @rachelkang!

vs-mobiletools-engineering-service2 · 2021-09-20T17:25:20Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 101 tests passed.

Failed tests

Xtro/Mac: Failed (Test run failed.)

Pipeline on Agent XAMBOT-1104.BigSur'
Merge b14b8cb into 499a69e

dalexsoto

Awesome! Only minor things

dalexsoto · 2021-09-21T16:08:04Z

src/intents.cs

@@ -6862,6 +6955,55 @@ interface INSetSeatSettingsInCarIntentResponse {
 		INSetSeatSettingsInCarIntentResponseCode Code { get; }
 	}

+	[Watch (8,0), NoTV, Mac (12,0), iOS (15,0), MacCatalyst (15,0)]
+	[BaseType (typeof(INIntent))]


Probably you want a DisableDefaultCtor here because there is no way to set FocusStatus unless the provided ctor is used

dalexsoto · 2021-09-21T16:12:24Z

src/intents.cs

+	{
+		[Export ("initWithIsFocused:")]
+		[DesignatedInitializer]
+		IntPtr Constructor ([NullAllowed] NSNumber isFocused);


You can use BindAs here, see swift docs

Suggested change

IntPtr Constructor ([NullAllowed] NSNumber isFocused);

IntPtr Constructor ([NullAllowed] [BindAs (typeof (bool?))] NSNumber isFocused);

dalexsoto · 2021-09-21T16:12:50Z

src/intents.cs

+		[DesignatedInitializer]
+		IntPtr Constructor ([NullAllowed] NSNumber isFocused);
+
+		[Export ("isFocused", ArgumentSemantic.Copy)]


Same, you can use BindAs to provide a better binding here

Suggested change

[Export ("isFocused", ArgumentSemantic.Copy)]

[Export ("isFocused", ArgumentSemantic.Copy)]

[BindAs (typeof (bool?))]

vs-mobiletools-engineering-service2 · 2021-09-21T21:50:56Z

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

iOS vsdrops gist
macOS vsdrops gist
macCat vsdrops gist
macCatiOS gist
tvOS vsdrops gist
watchOS vsdrops gist

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 101 tests passed.

Failed tests

dont link/Mac Catalyst [dotnet]/Release [dotnet]: TimedOut (Execution timed out after 1200 seconds.
No test log file was produced)

Pipeline on Agent XAMBOT-1097.BigSur'
Merge fc58ff1 into ae08971

dalexsoto · 2021-09-22T00:30:41Z

Unrelated test failure

https://github.com/xamarin/maccore/issues/2414

dalexsoto · 2021-09-22T00:31:15Z

/sudo backport xcode13-ios

vs-mobiletools-engineering-service2 · 2021-09-22T00:31:43Z

Backport Job to branch xcode13-ios Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2021-09-22T00:32:53Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5233974 for more details.

"[Intents] Update bindings for Xcode 13.0 betas 1 through 5"

d1ce9ff

rachelkang added the note-highlight Worth calling out specifically in release notes label Sep 17, 2021

rachelkang added this to the xcode13.0 milestone Sep 17, 2021

rachelkang requested a review from dalexsoto September 17, 2021 21:11

rachelkang requested review from chamons and rolfbjarne as code owners September 17, 2021 21:11

rolfbjarne requested changes Sep 20, 2021

View reviewed changes

Update based on feedback

b14b8cb

rolfbjarne requested changes Sep 20, 2021

View reviewed changes

tj-devel709 reviewed Sep 20, 2021

View reviewed changes

dalexsoto requested a review from mandel-macaque September 21, 2021 13:41

Update based on feedback

38928db

rolfbjarne approved these changes Sep 21, 2021

View reviewed changes

dalexsoto approved these changes Sep 21, 2021

View reviewed changes

Update based on feedback

fc58ff1

dalexsoto merged commit 70dd0d3 into xamarin:main Sep 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Intents] Update bindings for Xcode 13.0 betas 1 through 5 #12771

[Intents] Update bindings for Xcode 13.0 betas 1 through 5 #12771

rachelkang commented Sep 17, 2021

vs-mobiletools-engineering-service2 commented Sep 18, 2021

Failed tests

rolfbjarne Sep 20, 2021

rachelkang Sep 20, 2021

rolfbjarne Sep 20, 2021

rachelkang Sep 20, 2021

rolfbjarne Sep 20, 2021

tj-devel709 Sep 20, 2021

tj-devel709 Sep 20, 2021

tj-devel709 commented Sep 20, 2021 •

edited

Loading

rachelkang commented Sep 20, 2021

tj-devel709 commented Sep 20, 2021

vs-mobiletools-engineering-service2 commented Sep 20, 2021

Failed tests

dalexsoto left a comment

dalexsoto Sep 21, 2021

dalexsoto Sep 21, 2021

dalexsoto Sep 21, 2021

vs-mobiletools-engineering-service2 commented Sep 21, 2021

Failed tests

dalexsoto commented Sep 22, 2021

dalexsoto commented Sep 22, 2021

vs-mobiletools-engineering-service2 commented Sep 22, 2021

vs-mobiletools-engineering-service2 commented Sep 22, 2021


		[Watch (7,0), NoTV, NoMac, iOS (14,0)]
		interface INStartCallIntent : UNNotificationContentProviding {

	IntPtr Constructor ([NullAllowed] NSNumber isFocused);
	IntPtr Constructor ([NullAllowed] [BindAs (typeof (bool?))] NSNumber isFocused);

	[Export ("isFocused", ArgumentSemantic.Copy)]
	[Export ("isFocused", ArgumentSemantic.Copy)]
	[BindAs (typeof (bool?))]

[Intents] Update bindings for Xcode 13.0 betas 1 through 5 #12771

[Intents] Update bindings for Xcode 13.0 betas 1 through 5 #12771

Conversation

rachelkang commented Sep 17, 2021

vs-mobiletools-engineering-service2 commented Sep 18, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tj-devel709 commented Sep 20, 2021 • edited Loading

rachelkang commented Sep 20, 2021

tj-devel709 commented Sep 20, 2021

vs-mobiletools-engineering-service2 commented Sep 20, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

dalexsoto left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Sep 21, 2021

❌ [PR Build] Tests failed on Build ❌

API diff

API & Generator diff

GitHub pages

Test results

Failed tests

dalexsoto commented Sep 22, 2021

dalexsoto commented Sep 22, 2021

vs-mobiletools-engineering-service2 commented Sep 22, 2021

vs-mobiletools-engineering-service2 commented Sep 22, 2021

tj-devel709 commented Sep 20, 2021 •

edited

Loading