-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.NET/AudioUnit] Use [UnmanagedCallersOnly] instead of [MonoPInvokeCallback] for the ScheduledAudioFileRegionCallback function. #12948
[.NET/AudioUnit] Use [UnmanagedCallersOnly] instead of [MonoPInvokeCallback] for the ScheduledAudioFileRegionCallback function. #12948
Conversation
…llback] for the ScheduledAudioFileRegionCallback function. Ref xamarin#10470.
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 135 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
This is blocked on https://github.com/dotnet/runtime/issues/60113. |
@@ -24,7 +24,11 @@ public class AUScheduledAudioFileRegion : IDisposable { | |||
internal struct ScheduledAudioFileRegion | |||
{ | |||
public AudioTimeStamp TimeStamp; | |||
#if NET | |||
public unsafe delegate* unmanaged<IntPtr, ref ScheduledAudioFileRegion, AudioUnitStatus, void> CompletionHandler; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure this needs ref ScheduledAudioFileRegion
=> ScheduledAudioFileRegion *
. Same for the actual ScheduledAudioFileRegionCallback
callback below.
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 136 tests passed 🎉Pipeline on Agent XAMBOT-1101.BigSur' |
I found a workaround, so this isn't blocked anymore. |
Ref #10470.