Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET/AudioUnit] Use [UnmanagedCallersOnly] instead of [MonoPInvokeCallback] for the ScheduledAudioFileRegionCallback function. #12948

Merged

Conversation

rolfbjarne
Copy link
Member

Ref #10470.

…llback] for the ScheduledAudioFileRegionCallback function.

Ref xamarin#10470.
@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Oct 6, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 135 tests passed.

Failed tests

  • DotNet tests: Failed (Execution failed with exit code 1)

Pipeline on Agent XAMBOT-1094.BigSur'
Merge cdebbf2 into 2bc66b0

@rolfbjarne
Copy link
Member Author

@rolfbjarne rolfbjarne added the do-not-merge Do not merge this pull request label Oct 7, 2021
@@ -24,7 +24,11 @@ public class AUScheduledAudioFileRegion : IDisposable {
internal struct ScheduledAudioFileRegion
{
public AudioTimeStamp TimeStamp;
#if NET
public unsafe delegate* unmanaged<IntPtr, ref ScheduledAudioFileRegion, AudioUnitStatus, void> CompletionHandler;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this needs ref ScheduledAudioFileRegion => ScheduledAudioFileRegion *. Same for the actual ScheduledAudioFileRegionCallback callback below.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 136 tests passed 🎉

Pipeline on Agent XAMBOT-1101.BigSur'
Merge 9607cd9 into ed3d9fd

@rolfbjarne rolfbjarne removed the do-not-merge Do not merge this pull request label Oct 8, 2021
@rolfbjarne
Copy link
Member Author

I found a workaround, so this isn't blocked anymore.

@rolfbjarne rolfbjarne merged commit 9f2ff42 into xamarin:main Oct 8, 2021
@rolfbjarne rolfbjarne deleted the dotnet-unmanagedcallers-audiounit1 branch October 8, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants