[IntentsUI] Update bindings for Xcode13.0 betas 1, 4 #13056
Conversation
rachelkang
added
the
note-highlight
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 101 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
There was a problem hiding this comment.
@rachelkang looks good, I'm just wondering about the mac catalyst version.
| @@ -110,13 +125,14 @@ interface INUIAddVoiceShortcutViewController { | |||
| [NullAllowed, Export ("delegate", ArgumentSemantic.Weak)] | |||
| NSObject WeakDelegate { get; set; } | |||
|
|
|||
| [NoMacCatalyst] | |||
| [MacCatalyst (13,4)] | |||
There was a problem hiding this comment.
| @@ -143,13 +164,14 @@ interface INUIEditVoiceShortcutViewController { | |||
| [NullAllowed, Export ("delegate", ArgumentSemantic.Weak)] | |||
| NSObject WeakDelegate { get; set; } | |||
|
|
|||
| [NoMacCatalyst] | |||
| [MacCatalyst (13,4)] | |||
There was a problem hiding this comment.
| #if MONOMAC | ||
| [BaseType (typeof (NSViewController))] | ||
| #else | ||
| [BaseType (typeof (UIViewController))] | ||
| #endif |
There was a problem hiding this comment.
This could have done with a using, but I'm ok with it.
There was a problem hiding this comment.
For my future reference - what would be the alternative?
There was a problem hiding this comment.
nevermind, I misread! cool :)
|
test failure unrelated: https://github.com/xamarin/maccore/issues/2494 |
|
/sudo backport xcode13.1 |
|
Backport Job to branch **xcode13.1 ** Created! The magic is happening here |
|
Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5395344 for more details. |
Update bindings for Xcode13.0 betas 1, 4 (No diffs for betas 2,3,5,6)
Note that IntentsUI previously was not compiled on either Mac or MacCatalyst