Submodule MonoTouch.Dialog. #13058
Merged
Submodule MonoTouch.Dialog. #13058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule MonoTouch.Dialog, so that we can easily build it using .NET. This submodule will become redundant when/if we publish a .NET version of MonoTouch.Dialog, but until that happens we need it at least for our own test suites. This also means we have to copy our NuGet.config and global.json files to the MonoTouch.Dialog project directory so that we point msbuild to use our local build. New commits in spouliot/Touch.Unit: * xamarin/Touch.Unit@cbda703 [Touch.Client] Use MonoTouch.Dialog from a submodule. (xamarin#109) Diff: https://github.com/spouliot/Touch.Unit/compare/3345db2f4e6408fdf2e8f099251c5c1310b56937..cbda70358360329854ea399100a2b5b04ae43982
rolfbjarne
added
not-notes-worthy
mandel-macaque
approved these changes
Oct 20, 2021
And fix indentation and set the branch name.
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 193 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
chamons
approved these changes
Oct 21, 2021
tj-devel709
approved these changes
Oct 21, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 192 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
…rectly. The projects get the MonoTouch.Dialog reference indirectly through the Touch.Client project reference.
…ctly in the MonoTouch.Dialog project.
…an NUnit issue everywhere.
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 193 tests passed.Failed tests
Pipeline on Agent XAMBOT-1099.BigSur' |
… bundle. This fixes an issue where a library project would try (and fail) to create a package when 'CreatePackage=true' (which could be set for the executable project, but inherited by the library project since the executable project depends on it).
…emblyName property. MSBuild ends up being very confused when the project we're trying to build depends on other projects, because AssemblyName is set for all the projects being build, and MSBuild complains about ambiguous projects: > error: Ambiguous project name 'bindings-xcframework-test'
dalexsoto
approved these changes
Oct 25, 2021
emaf
approved these changes
Oct 25, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffView dotnet API diffView dotnet legacy API diffGitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results4 tests failed, 190 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
|
Test failures are unrelated:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submodule MonoTouch.Dialog, so that we can easily build it using .NET. This
submodule will become redundant when/if we publish a .NET version of
MonoTouch.Dialog, but until that happens we need it at least for our own test
suites.
This also means we have to copy our NuGet.config and global.json files to the
MonoTouch.Dialog project directory so that we point msbuild to use our local
build.
New commits in spouliot/Touch.Unit:
Diff: https://github.com/spouliot/Touch.Unit/compare/3345db2f4e6408fdf2e8f099251c5c1310b56937..cbda70358360329854ea399100a2b5b04ae43982