Prepare for NET6 attribute conversion with hand fixes #13658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The tool I wrote to convert attributes [mellite](https://github.com/chamons/mellite) does single pass through each file - This means files that define Foo and !Foo, each with availability attributes inside can not be proccessed - These 2 locations were easy to fix by moving defines inside binding definations, so I did that - About 10 other locations were not so easy, so those will be worked around by hand in the conversion process. Part of xamarin#10170
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 108 tests passed 🎉Pipeline on Agent XAMBOT-1094.BigSur' |
|
API diff looks clean. |
dalexsoto
approved these changes
Jan 7, 2022
mandel-macaque
approved these changes
Jan 7, 2022
src/foundation.cs
Outdated
| public enum NSFileManagerUnmountOptions : ulong | ||
| { | ||
| AllPartitionsAndEjectDisk = 1 << 0, | ||
| WithoutUI = 1 << 1 |
There was a problem hiding this comment.
Shall we add the missing ',' since we are moving it?
src/avkit.cs
Outdated
| [Native] | ||
| public enum AVPlayerViewTrimResult : long { | ||
| OKButton, | ||
| CancelButton |
There was a problem hiding this comment.
Shall we add the ',' since we are moving it?
tj-devel709
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #10170