Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIP] Updates for Xcode13.2 beta 1 #13884

Merged
merged 9 commits into from
Jan 31, 2022

Conversation

rachelkang
Copy link
Contributor

@rachelkang rachelkang commented Jan 26, 2022

CHIP updates for Xcode13.2 beta 1

Related notes:

System.InvalidOperationDexception : Could not create the new instance for type CGEvent
at Introspection.ApiCMAttachmentTest.GetINativeInstance(Type t) in xamarin-macios/tests/introspection/ApiCMAttachmentTest.cs:line 490
at Introspection.ApiCMAttachmentTest.CheckFailAttachments() xamarin-macios/tests/introspection/ApiCMAttachmentTest.cs:line 564
at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

@rachelkang rachelkang added the note-highlight Worth calling out specifically in release notes label Jan 26, 2022
@rachelkang rachelkang added this to the xcode13.2 milestone Jan 26, 2022
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

4 tests failed, 104 tests passed.

Failed tests

  • introspection/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 37 Passed: 34 Inconclusive: 0 Failed: 1 Ignored: 2)
  • introspection/Mac Modern/Debug: Failed (Test run failed.
    Tests run: 37 Passed: 35 Inconclusive: 0 Failed: 1 Ignored: 1)
  • Xtro/.NET: BuildFailure
  • Cecil-based tests/NUnit: Failed (Execution failed with exit code 6)

Pipeline on Agent XAMBOT-1096.BigSur'
Merge b016e73 into 02644ca

Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quite the read! Good job

src/Chip/ChipCompat.cs Outdated Show resolved Hide resolved
src/chip.cs Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Outdated Show resolved Hide resolved
src/chip.cs Show resolved Hide resolved
src/chip.cs Show resolved Hide resolved
src/chip.cs Show resolved Hide resolved
src/chip.cs Show resolved Hide resolved
src/chip.cs Show resolved Hide resolved
src/chip.cs Show resolved Hide resolved
@rachelkang
Copy link
Contributor Author

@rolfbjarne Thanks for the quick and thorough review as always!

@tj-devel709
Copy link
Contributor

Perhaps add an issue for this Xtro is failing due to a missing binding in Intents - will create a separate PR for this and assign it to yourself just in case

src/chip.cs Outdated
@@ -70,7 +73,6 @@ public enum ChipOptionalQRCodeInfoType : ulong {
Int32,
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra new line

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests didn't execute on Build. ❌

Tests didn't execute on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

No test summary was found (something probably failed before the tests could execute)

Pipeline on Agent
Merge a11fc96 into 9695bf2

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

3 tests failed, 105 tests passed.

Failed tests

  • introspection/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 37 Passed: 34 Inconclusive: 0 Failed: 1 Ignored: 2)
  • introspection/Mac Modern/Debug: Failed (Test run failed.
    Tests run: 37 Passed: 35 Inconclusive: 0 Failed: 1 Ignored: 1)
  • Xtro/.NET: BuildFailure

Pipeline on Agent XAMBOT-1042.BigSur'
Merge 48d4cea into 401bf76

Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of todo entries can/must be removed from xtro as well :)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 107 tests passed.

Failed tests

  • Xtro/.NET: BuildFailure

Pipeline on Agent XAMBOT-1101.BigSur'
Merge f42c90b into cf043fa

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 146 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 2767 Passed: 2571 Inconclusive: 11 Failed: 1 Ignored: 195)
  • trimmode copy/Mac Catalyst [dotnet]/Debug [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)

Pipeline on Agent XAMBOT-1098.BigSur'
Merge 61c4eab into 5cf3e0a

@rachelkang
Copy link
Contributor Author

Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are the following breaking changes:

Chip.ChipBinaryInputBasic

Modified methods:

-public virtual void WriteAttributeOutOfService (byte value, ChipResponseHandler responseHandler)
+public void WriteAttributeOutOfService (byte value, ChipResponseHandler responseHandler)
-public virtual System.Threading.Tasks.Task WriteAttributeOutOfServiceAsync (byte value)
+public System.Threading.Tasks.Task WriteAttributeOutOfServiceAsync (byte value)
-public virtual void WriteAttributePresentValue (byte value, ChipResponseHandler responseHandler)
+public void WriteAttributePresentValue (byte value, ChipResponseHandler responseHandler)
-public virtual System.Threading.Tasks.Task WriteAttributePresentValueAsync (byte value)
+public System.Threading.Tasks.Task WriteAttributePresentValueAsync (byte value)

Chip.ChipBinding

-public virtual void Bind (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId, ChipResponseHandler responseHandler)
+public void Bind (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId, ChipResponseHandler responseHandler)
-public virtual System.Threading.Tasks.Task BindAsync (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId)
+public System.Threading.Tasks.Task BindAsync (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId)
-public virtual void Unbind (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId, ChipResponseHandler responseHandler)
+public void Unbind (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId, ChipResponseHandler responseHandler)
-public virtual System.Threading.Tasks.Task UnbindAsync (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId)
+public System.Threading.Tasks.Task UnbindAsync (ulong nodeId, ushort groupId, byte endpointId, ushort clusterId)

Chip.ChipTemperatureMeasurement

-public virtual void WriteAttributeBoolean (byte value, ChipResponseHandler responseHandler)
+public void WriteAttributeBoolean (byte value, ChipResponseHandler responseHandler)
-public virtual System.Threading.Tasks.Task WriteAttributeBooleanAsync (byte value)
+public System.Threading.Tasks.Task WriteAttributeBooleanAsync (byte value)

Please take a look at the full diff in the comment from the bots. You are probably missing virtual from some manual code you added to not change the api.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 147 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 2764 Passed: 2568 Inconclusive: 11 Failed: 4 Ignored: 192)

Pipeline on Agent XAMBOT-1109.BigSur'
Merge 1fb2d43 into 39ec61d

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

4 tests failed, 144 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: TimedOut
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Crashed
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Crashed
  • monotouch-test/watchOS 32-bits - simulator/Release (all optimizations): Crashed

Pipeline on Agent XAMBOT-1094.BigSur'
Merge 893a031 into 39ec61d

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

ℹ️ Generator Diff (please review changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

🎉 All 148 tests passed 🎉

Pipeline on Agent XAMBOT-1109.BigSur'
Merge d11a0de into 0ce1501

Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply the small cleaning comments.

//
// Authors:
// Rachel Kang <rachelkang@microsoft.com>
//com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//com

//
// Authors:
// Rachel Kang <rachelkang@microsoft.com>
//com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//com

@rachelkang rachelkang merged commit a64b03a into xamarin:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
note-highlight Worth calling out specifically in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants