Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Foundation] Make NSUserDefaults.VolatileDomainNames a property in XAMCORE_5_0. #14942

Merged
merged 1 commit into from
May 9, 2022

Conversation

rolfbjarne
Copy link
Member

That's how it's in Swift.

@rolfbjarne rolfbjarne requested a review from chamons as a code owner May 9, 2022 14:21
@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes skip-all-tests Skip all the tests labels May 9, 2022
@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [CI Build] Artifacts 📚

Artifacts were not provided.

Pipeline on Agent XAMBOT-1099.Monterey
Hash: 6f94e6eac5602b6d05c29461ad0aa3e900d6111b

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: 6f94e6eac5602b6d05c29461ad0aa3e900d6111b

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📋 [PR Build] API Diff 📋

API Current PR diff

✅ API Diff (from PR only) (no change)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

Generator Diff (no change)

Pipeline on Agent XAMBOT-1030.Monterey
Hash: 6f94e6eac5602b6d05c29461ad0aa3e900d6111b

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • linksdk
  • linkall
  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: 6f94e6eac5602b6d05c29461ad0aa3e900d6111b

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build] Tests passed on VSTS: simulator tests iOS. ✅

Tests passed on VSTS: simulator tests iOS.

🎉 All 2 tests passed 🎉

Pipeline on Agent XAMBOT-1099.Monterey'
Merge 6f94e6e into 5631ca5

@rolfbjarne rolfbjarne merged commit 32c29c1 into xamarin:main May 9, 2022
@rolfbjarne rolfbjarne deleted the tests-improve-networking branch May 9, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes skip-all-tests Skip all the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants