[tools] Make sure to finish the P/Invoke generator output before running the static registrar. Fixes #15190. #15214
Conversation
…ing the static registrar. Fixes xamarin#15190. Otherwise the P/Invoke generator leaves partial results in the static registrar class, essentially saying things like "we've processed CoreMidi, no need to add an #include for this framework", and then we'd generate the static registrar code and that code would lack the #include for CoreMidi. Finishing the P/Invoke generator output will clear out any state stored in the static registrar. Fixes xamarin#15190.
…ents where the structs come from
…eGraphics.RMatrix3 is GLKMatrix3
This comment has been minimized.
This comment has been minimized.
🔥 Tests failed catastrophically on VSTS: simulator tests iOS (no summary found). 🔥Result file D:\a\1\s\Reports\TestSummary-simulator\TestSummary.md not found. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Tests on macOS M1 - Mac Big Sur (11.5) failed for unknown reasons. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Artifacts were not provided. Pipeline on Agent XAMBOT-1107.Monterey' |
📋 [PR Build] API Diff 📋API diff (for current PR)ℹ️ API Diff (from PR only) (please review changes) .NETXamarin vs .NETAPI diff (vs stable)✅ API Diff from stable .NETXamarin vs .NETGenerator diff✅ Generator Diff (no change) Pipeline on Agent XAMBOT-1108.Monterey |
❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌Failed tests are:
Pipeline on Agent |
❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌Tests failed on VSTS: simulator tests iOS. Test results3 tests failed, 148 tests passed.Failed tests
Pipeline on Agent XAMBOT-1107.Monterey' |
|
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2558) |
Otherwise the P/Invoke generator leaves partial results in the static
registrar class, essentially saying things like "we've processed CoreMidi, no
need to add an #include for this framework", and then we'd generate the static
registrar code and that code would lack the #include for CoreMidi.
Finishing the P/Invoke generator output will clear out any state stored in the
static registrar.
Also fix a few other issues to make the generated P/Invoke wrapper code work,
and add a test.
Fixes #15190.