[introspection] Fix according to macOS 12.4. Fixes #15229. #15230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ignore anything Chip-related, the framework was removed from macOS. * Fix reporting errors some protocol-related errors so that they're actually reported as errors (by calling 'ReportError' instead of just adding the errors to a list that doesn't affect anything else). * Ignore the NSUserActivityRestoring protocol, according to the macOS headers it's attached to NSResponder using a category, which is invisible at runtime. Due to the previous point this didn't show up before, but once at least another error (which happened with the Chip framework), then this was listed as well. Fixes xamarin#15229.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dalexsoto
approved these changes
Jun 9, 2022
mandel-macaque
approved these changes
Jun 9, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
❗ API diff vs stable (Breaking changes)Legacy Xamarin (No breaking changes).NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
✅ Generator diffGenerator diff is empty Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌Failed tests are:
Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
|
Test failures are unrelated:
|
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jun 16, 2022
…marin#15230) * Ignore anything Chip-related, the framework was removed from macOS. * Fix reporting errors some protocol-related errors so that they're actually reported as errors (by calling 'ReportError' instead of just adding the errors to a list that doesn't affect anything else). * Ignore the NSUserActivityRestoring protocol, according to the macOS headers it's attached to NSResponder using a category, which is invisible at runtime. Due to the previous point this didn't show up before, but once at least another error (which happened with the Chip framework), then this was listed as well. * Add ignores for a couple of protocols. Fixes xamarin#15229.
rolfbjarne
added a commit
to rolfbjarne/xamarin-macios
that referenced
this pull request
Jun 16, 2022
…marin#15230) * Ignore anything Chip-related, the framework was removed from macOS. * Fix reporting errors some protocol-related errors so that they're actually reported as errors (by calling 'ReportError' instead of just adding the errors to a list that doesn't affect anything else). * Ignore the NSUserActivityRestoring protocol, according to the macOS headers it's attached to NSResponder using a category, which is invisible at runtime. Due to the previous point this didn't show up before, but once at least another error (which happened with the Chip framework), then this was listed as well. * Add ignores for a couple of protocols. Fixes xamarin#15229.
rolfbjarne
added a commit
that referenced
this pull request
Jun 16, 2022
rolfbjarne
added a commit
that referenced
this pull request
Jun 17, 2022
This was referenced Jun 21, 2022
|
/sudo backport d17-2 |
|
Backport Job to branch d17-2 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6420603 for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported as errors (by calling 'ReportError' instead of just adding the
errors to a list that doesn't affect anything else).
it's attached to NSResponder using a category, which is invisible at
runtime. Due to the previous point this didn't show up before, but once at
least another error (which happened with the Chip framework), then this was
listed as well.
Fixes #15229.