Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime] Fix 'skip_nested_brace' to not read past the string. Fixes #15253. #15257

Merged
merged 1 commit into from
Jun 14, 2022
Merged

[runtime] Fix 'skip_nested_brace' to not read past the string. Fixes #15253. #15257

merged 1 commit into from
Jun 14, 2022

Conversation

rolfbjarne
Copy link
Member

Fix 'skip_nested_brace' to not double skip characters.

Also add a test.

Fixes #15253.

@rolfbjarne
[runtime] Fix 'skip_nested_brace' to not read past the string. Fixes x…
c7de9a6 
…amarin#15253.

Fix 'skip_nested_brace' to not double skip characters.

Also add a test.

Fixes xamarin#15253.
@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Jun 13, 2022
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻

✅ All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent
Hash: c7de9a6cd7e00109f792efca6738ff25ec247ab0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1033.Monterey'
Hash: c7de9a6cd7e00109f792efca6738ff25ec247ab0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: c7de9a6cd7e00109f792efca6738ff25ec247ab0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • xammac_tests
  • monotouch-test

Pipeline on Agent
Hash: c7de9a6cd7e00109f792efca6738ff25ec247ab0 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [CI Build] Tests failed on VSTS: simulator tests iOS ❌

Tests failed on VSTS: simulator tests iOS.

Test results

1 tests failed, 145 tests passed.

Failed tests

  • fsharp/watchOS 32-bits - simulator/Debug: Crashed

Pipeline on Agent XAMBOT-1037.Monterey'
Merge c7de9a6 into 0fa87fe

dalexsoto
dalexsoto approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoah what a subtle one 👍

@rolfbjarne
Copy link
Member Author

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2558).

@rolfbjarne rolfbjarne merged commit 8adbefd into xamarin:main Jun 14, 2022
@rolfbjarne rolfbjarne deleted the issue-15253 branch June 14, 2022 12:26
@rolfbjarne
Copy link
Member Author

/sudo backport release/6.0.3xx

@rolfbjarne
Copy link
Member Author

/sudo backport release/6.0.4xx

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.3xx Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.4xx Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6400947 for more details.

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6400946 for more details.

rolfbjarne added a commit that referenced this pull request Jul 14, 2022
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/6.0.3xx] [runtime] Fix 'skip_nested_brace' to not read past …
5889016 
…the string. Fixes #15253. (#15462)

Fix 'skip_nested_brace' to not double skip characters.

Also add a test.

Fixes #15253.


Backport of #15257

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
rolfbjarne added a commit that referenced this pull request Jul 14, 2022
@vs-mobiletools-engineering-service2 @rolfbjarne
[release/6.0.4xx] [runtime] Fix 'skip_nested_brace' to not read past …
f14488f 
…the string. Fixes #15253. (#15461)

Fix 'skip_nested_brace' to not double skip characters.

Also add a test.

Fixes #15253.


Backport of #15257

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@filipnavara filipnavara filipnavara approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@tj-devel709 tj-devel709 tj-devel709 approved these changes

Assignees
No one assigned
Labels
bug If an issue is a bug or a pull request a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash in native code with keyboard viewer + japan keyboard
6 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @filipnavara @mandel-macaque @tj-devel709