-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CloudKit] Update bindings for Xcode 14 beta 1and2 #15546
[CloudKit] Update bindings for Xcode 14 beta 1and2 #15546
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
||
[TV (16,0), NoWatch, Mac (13,0), iOS (16,0), MacCatalyst (16,0)] | ||
[BaseType (typeof (NSObject))] | ||
interface CKAllowedSharingOptions : NSSecureCoding, NSCopying |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs a [DisableDefaultCtor]
since there is a native ctor
interface CKAllowedSharingOptions : NSSecureCoding, NSCopying | |
[DisableDefaultCtor] | |
interface CKAllowedSharingOptions : NSSecureCoding, NSCopying |
src/cloudkit.cs
Outdated
NativeHandle Constructor (CKContainer container); | ||
|
||
[NullAllowed, Export ("systemSharingUIDidSaveShareBlock", ArgumentSemantic.Copy)] | ||
Action<CKRecordID, CKShare, NSError> SystemSharingUIDidSaveShareBlock { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Action<CKRecordID, CKShare, NSError> SystemSharingUIDidSaveShareBlock { get; set; } | |
Action<CKRecordID, CKShare, NSError> SystemSharingUIDidSaveShareHandler { get; set; } |
src/cloudkit.cs
Outdated
Action<CKRecordID, CKShare, NSError> SystemSharingUIDidSaveShareBlock { get; set; } | ||
|
||
[NullAllowed, Export ("systemSharingUIDidStopSharingBlock", ArgumentSemantic.Copy)] | ||
Action<CKRecordID, NSError> SystemSharingUIDidStopSharingBlock { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Action<CKRecordID, NSError> SystemSharingUIDidStopSharingBlock { get; set; } | |
Action<CKRecordID, NSError> SystemSharingUIDidStopSharingHandler { get; set; } |
src/foundation.cs
Outdated
|
||
// extension methods from CloudKit | ||
|
||
[Async] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This async looks like may be troublesome, it is not a completion handler but a preparation handler we do not know when this is called so I would remove the Async here
[Async] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, does look like it will be execute before anything happens, that means that if we callout async we would have a completely wrong behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, wrong option selected ^ :P
src/CloudKit/Enums.cs
Outdated
{ | ||
ReadOnly = 1uL << 0, | ||
ReadWrite = 1uL << 1, | ||
Any = ReadOnly | ReadWrite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, missing comma.
Any = ReadOnly | ReadWrite | |
Any = ReadOnly | ReadWrite, |
src/cloudkit.cs
Outdated
} | ||
|
||
[NoWatch, NoTV, Mac (13,0), iOS (16,0), MacCatalyst (16,0)] | ||
delegate void CKSharePreparationHandler (); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use Action?
src/foundation.cs
Outdated
[Async] | ||
[NoWatch, NoTV, Mac (13,0), iOS (16,0), MacCatalyst (16,0)] | ||
[Export ("registerCKShareWithContainer:allowedSharingOptions:preparationHandler:")] | ||
void RegisterCKShare (CKContainer container, CKAllowedSharingOptions allowedOptions, CKSharePreparationHandler preparationHandler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
void RegisterCKShare (CKContainer container, CKAllowedSharingOptions allowedOptions, CKSharePreparationHandler preparationHandler); | |
void RegisterCKShare (CKContainer container, CKAllowedSharingOptions allowedOptions, Action preparationHandler); |
src/foundation.cs
Outdated
|
||
// extension methods from CloudKit | ||
|
||
[Async] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, does look like it will be execute before anything happens, that means that if we callout async we would have a completely wrong behaviour.
@dalexsoto @mandel-macaque Requested changes addressed! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 3 tests failed, 225 tests passed. Failures❌ cecil tests
Html Report (VSDrops) Download ❌ introspection tests
Html Report (VSDrops) Download ❌ xtro tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xtrotests are unrelated, cecil tests are known: https://github.com/xamarin/maccore/issues/2607
No description provided.