-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[runtime] Add some debugging aid to xamarin_release_managed_ref. #15767
Conversation
It's fairly frequent (due to various types of coding errors) to have the call to '[self release]' in xamarin_release_managed_ref crash. These crashes are typically very hard to diagnose, because it can be hard to figure out which object caused the crash. So now we store the native object in a static variable, so that it can be read using lldb from a core dump. Ref: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1481312.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope it's not a case where the handle is already nulled out at this point.
@Therzok the crash would look different if that was the case |
🔥 Failed to compare API and create generator diff 🔥 Error: 'make' failed for the hash 1228fda. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 1 tests failed, 222 tests passed. Failures❌ mmp tests
Html Report (VSDrops) Download Successes✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2612). |
Can you please backport this to 6.x release branch? |
@Therzok this will be included in our Xcode 14 release, which will most likely be out later this month. |
It's fairly frequent (due to various types of coding errors) to have the
call to '[self release]' in xamarin_release_managed_ref crash. These
crashes are typically very hard to diagnose, because it can be hard to
figure out which object caused the crash. So now we store the native
object in a static variable, so that it can be read using lldb from a core
dump.
Ref: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1481312.