Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UIkit] Add generic callbacks for UIGestureRecognizer #15846

Merged
merged 3 commits into from
Sep 2, 2022
Merged

[UIkit] Add generic callbacks for UIGestureRecognizer #15846

merged 3 commits into from
Sep 2, 2022

Conversation

haritha-mohan
Copy link
Contributor

Simplifies code and makes bug easier to fix.

@haritha-mohan haritha-mohan added the not-notes-worthy Ignore for release notes label Sep 1, 2022
@mandel-macaque mandel-macaque changed the title Add generic callbacks [UIkit] Add generic callbacks for UIGestureRecognizer Sep 1, 2022
mandel-macaque
mandel-macaque requested changes Sep 1, 2022
View reviewed changes
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change

src/UIKit/UIGestureRecognizer.cs Outdated Show resolved Hide resolved
mandel-macaque
mandel-macaque requested changes Sep 1, 2022
View reviewed changes
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change in visibility.

@haritha-mohan @mandel-macaque
Update src/UIKit/UIGestureRecognizer.cs
e9c626c 
Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
dalexsoto
dalexsoto reviewed Sep 1, 2022
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the change but it may not work, let me think a little
My bad! I was thinking of something else

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
rolfbjarne
rolfbjarne approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@rolfbjarne rolfbjarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, less code is always good!

@haritha-mohan @mandel-macaque
Apply suggestions from code review
298a1d4 
Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
@mandel-macaque mandel-macaque merged commit 0d55330 into xamarin:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@haritha-mohan @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @mandel-macaque