Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Hot Restart fixes #15979

Merged
merged 3 commits into from
Sep 16, 2022
Merged

[msbuild] Hot Restart fixes #15979

merged 3 commits into from
Sep 16, 2022

Conversation

emaf
Copy link
Contributor

@emaf emaf commented Sep 15, 2022

Adds missing css files needed on Maui Blazor apps and avoids copying unnecessary files into the bundle (overdue task since the .NET migration).

@emaf
[msbuild] Include MauiAssets into the Hot Restart bundle
63d5c73 
We were missing to copy MauiAssets, like css styles for Maui Blazor apps, into the Hot Restart app bundle.

Fixes https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_workitems/edit/1540183
@emaf
[msbuild] Avoid copying unnecessary files to the Hot Restart app
3b9f125 
From the comment in this line, this is a long overdue task.

We should avoid copying duplicated or unnecessary files to the Hot Restart Content folder to reduce the bundle size.
@mauroa mauroa added the not-notes-worthy Ignore for release notes label Sep 15, 2022
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 Failed to compute test summaries on VSTS: simulator tests 🔥

Failed to compute test summaries: The term 'New-TestSummaryResults' is not recognized as a name of a cmdlet, function, script file, or executable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again..

Pipeline on Agent
Merge 3b9f125 into fbb39bc

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

No test package could be found for tests on macOS M1 - Mac Big Sur (11.5)

Pipeline on Agent
Hash: f8b8183c69a834bbe0b40e5b6e087636b4a03a68 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS Mac Catalina (10.15) failed ❌

No test package could be found for tests on macOS Mac Catalina (10.15)

Pipeline on Agent
Hash: f8b8183c69a834bbe0b40e5b6e087636b4a03a68 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: f8b8183c69a834bbe0b40e5b6e087636b4a03a68 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1043.Monterey'
Hash: f8b8183c69a834bbe0b40e5b6e087636b4a03a68 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 222 tests passed.

Failures

❌ dotnettests tests

1 tests failed, 0 tests passed.
  • DotNet tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne
Copy link
Member

Test failures are unrelated (#15986).

@rolfbjarne rolfbjarne merged commit 4b49ddd into main Sep 16, 2022
@rolfbjarne rolfbjarne deleted the dev/ema/maui branch September 16, 2022 15:31
@emaf
Copy link
Contributor Author

emaf commented Sep 16, 2022

/sudo backport release/6.0.4xx

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.4xx Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6700029 for more details.

@emaf
Copy link
Contributor Author

emaf commented Sep 16, 2022

/sudo backport 6.0.4xx-xcode14

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch 6.0.4xx-xcode14 Created! The magic is happening here

@emaf
Copy link
Contributor Author

emaf commented Sep 16, 2022

/sudo backport release/6.0.4xx-xcode14

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.4xx-xcode14 Created! The magic is happening here

@emaf
Copy link
Contributor Author

emaf commented Sep 16, 2022

/sudo backport release/7.0.1xx-rc2

@emaf
Copy link
Contributor Author

emaf commented Sep 16, 2022

/sudo backport release/7.0.1xx-xcode14-rc2

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.1xx-rc2 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.1xx-xcode14-rc2 Created! The magic is happening here

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6700148 for more details.

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6700154 for more details.

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6700156 for more details.

dalexsoto pushed a commit that referenced this pull request Sep 18, 2022
@vs-mobiletools-engineering-service2 @emaf
[release/6.0.4xx] [msbuild] Hot Restart fixes (#16002)
c173012 
Adds missing css files needed on Maui Blazor apps and avoids copying
unnecessary files into the bundle (overdue task since the .NET
migration).


Backport of #15979

Co-authored-by: Emanuel Fernandez Dell'Oca <ema@xamarin.com>
dalexsoto pushed a commit that referenced this pull request Sep 18, 2022
@vs-mobiletools-engineering-service2 @emaf
[release/6.0.4xx-xcode14] [msbuild] Hot Restart fixes (#16003)
be07d04 
Adds missing css files needed on Maui Blazor apps and avoids copying
unnecessary files into the bundle (overdue task since the .NET
migration).


Backport of #15979

Co-authored-by: Emanuel Fernandez Dell'Oca <ema@xamarin.com>
rolfbjarne pushed a commit that referenced this pull request Sep 19, 2022
@vs-mobiletools-engineering-service2 @emaf
[release/7.0.1xx-xcode14-rc2] [msbuild] Hot Restart fixes (#16005)
5bce0b9 
Adds missing css files needed on Maui Blazor apps and avoids copying unnecessary files into the bundle (overdue task since the .NET migration).


Backport of #15979

Co-authored-by: Emanuel Fernandez Dell'Oca <ema@xamarin.com>
rolfbjarne pushed a commit that referenced this pull request Sep 19, 2022
@vs-mobiletools-engineering-service2 @emaf
[release/7.0.1xx-rc2] [msbuild] Hot Restart fixes (#16004)
c20e4f9 
Adds missing css files needed on Maui Blazor apps and avoids copying unnecessary files into the bundle (overdue task since the .NET migration).


Backport of #15979

Co-authored-by: Emanuel Fernandez Dell'Oca <ema@xamarin.com>
@MackinnonBuck
Copy link

@emaf Do you think dotnet/maui#7468 is related to the CSS issue that this PR fixed?

@MackinnonBuck MackinnonBuck mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@mauroa mauroa mauroa approved these changes

@chamons chamons chamons approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@emaf @vs-mobiletools-engineering-service2 @rolfbjarne @MackinnonBuck @dalexsoto @mauroa @chamons