-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[StoreKit] Added support for Xcode 14.1 b1-b3 #16026
[StoreKit] Added support for Xcode 14.1 b1-b3 #16026
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4d920d4
to
110537a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
110537a
to
f1af4c6
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/storekit.cs
Outdated
@@ -995,21 +1001,33 @@ interface SKAdNetwork { | |||
[Static] | |||
[Async] | |||
[Export ("startImpression:completionHandler:")] | |||
void StartImpression (SKAdImpression impression, [NullAllowed] Action<NSError> completion); | |||
void StartImpression (SKAdImpression impression, [NullAllowed] SKAdNetworkCompletionHandler completion); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change, you can only add a new overload, not change existing parameter types.
src/storekit.cs
Outdated
|
||
[NoWatch, NoTV, NoMac] | ||
[iOS (14,5)] | ||
[MacCatalyst (14,5)] | ||
[Static] | ||
[Async] | ||
[Export ("endImpression:completionHandler:")] | ||
void EndImpression (SKAdImpression impression, [NullAllowed] Action<NSError> completion); | ||
void EndImpression (SKAdImpression impression, [NullAllowed] SKAdNetworkCompletionHandler completion); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
src/storekit.cs
Outdated
|
||
[NoWatch, NoTV, NoMac, iOS (15,4), MacCatalyst (15,4)] | ||
[Static] | ||
[Async] | ||
[Export ("updatePostbackConversionValue:completionHandler:")] | ||
void UpdatePostback (nint conversionValue, [NullAllowed] Action<NSError> completion); | ||
void UpdatePostback (nint conversionValue, [NullAllowed] SKAdNetworkCompletionHandler completion); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes).NET (No breaking changes)❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:).NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 19 tests failed, 209 tests passed. Failures❌ bcl tests
Html Report (VSDrops) Download ❌ introspection tests
Html Report (VSDrops) Download ❌ linker tests
Html Report (VSDrops) Download ❌ monotouch tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Failures are unrelated. |
No description provided.