Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreLocation] Added support for Xcode 14.1 b1 #16119

Merged
merged 8 commits into from
Oct 11, 2022

Conversation

SotoiGhost
Copy link
Contributor

No description provided.

@SotoiGhost SotoiGhost added the notes-mention Deserves a mention in release notes label Sep 23, 2022
@SotoiGhost SotoiGhost added this to the xcode14.1 milestone Sep 23, 2022
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@mandel-macaque mandel-macaque marked this pull request as ready for review October 3, 2022 16:06
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

src/CoreLocation/CLEnums.cs Outdated Show resolved Hide resolved
src/corelocation.cs Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Copy link
Contributor

@tj-devel709 tj-devel709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question about version!

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 3af457deed48647f46e3019059b734a0dd009854 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1164.Monterey'
Hash: 3af457deed48647f46e3019059b734a0dd009854 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

  • monotouch-test

Pipeline on Agent
Hash: 3af457deed48647f46e3019059b734a0dd009854 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 14 tests failed, 214 tests passed.

Failures

❌ bcl tests

6 tests failed, 63 tests passed.
  • [NUnit] Mono BCL tests group 1/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
  • [xUnit] Mono BCL tests group 3/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
  • [xUnit] Mono BCL tests group 4/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
  • mscorlib Part 1/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
  • [xUnit] Mono SystemCoreXunit Part 1/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut
  • [xUnit] Mono SystemCoreXunit Part 2/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ framework tests

1 tests failed, 7 tests passed.
  • framework-test/iOS Unified 64-bits - simulator/Debug [dotnet]: LaunchTimedOut

Html Report (VSDrops) Download

❌ introspection tests

1 tests failed, 12 tests passed.
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 6.0): Crashed Known issue: HE0038)

Html Report (VSDrops) Download

❌ linker tests

4 tests failed, 61 tests passed.
  • dont link/iOS Unified 64-bits - simulator/Release [dotnet]: LaunchTimedOut
  • dont link/iOS Unified 64-bits - simulator/Release: LaunchTimedOut
  • link all/iOS Unified 64-bits - simulator/Debug [dotnet]: LaunchTimedOut
  • link sdk/iOS Unified 64-bits - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ monotouch tests

1 tests failed, 22 tests passed.
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk) [dotnet]: LaunchTimedOut

Html Report (VSDrops) Download

❌ mtouch tests

1 tests failed, 0 tests passed.
  • MTouch tests/NUnit: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@mandel-macaque mandel-macaque merged commit 1e877a8 into xamarin:xcode14.1 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-mention Deserves a mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants