Disable objc_msgSend stubs in clang. Fixes #16223. #16231
Conversation
Clang will by default emit objc_msgSend stubs in Xcode 14, which ld from earlier Xcodes doesn't understand. We disable this by passing -fno-objc-msgsend-selector-stubs to clang. Ref: https://developer.apple.com/videos/play/wwdc2022/110363/ Ref: https://www.wwdcnotes.com/notes/wwdc22/110363/ Ref: llvm/llvm-project#56034 Fixes xamarin#16223.
|
/sudo backport release/7.0.1xx-xcode14-rc2 |
|
/sudo backport release/net7.0-xcode14 |
|
Backport Job to branch release/7.0.1xx-xcode14-rc2 Created! The magic is happening here |
|
Backport Job to branch release/net7.0-xcode14 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6778187 for more details. |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
❗ API diff vs stable (Breaking changes)Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:).NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS Mac Catalina (10.15) passed 💻✅ All tests on macOS Mac Catalina (10.15) passed. Pipeline on Agent |
❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌Failed tests are:
Pipeline on Agent |
|
/sudo backport net7.0-xcode14 |
|
Backport Job to branch net7.0-xcode14 Created! The magic is happening here |
|
Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6778416 for more details. |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: simulator tests 0 tests crashed, 7 tests failed, 221 tests passed. Failures❌ bcl tests
Html Report (VSDrops) Download ❌ introspection tests
Html Report (VSDrops) Download ❌ linker tests
Html Report (VSDrops) Download ❌ mtouch tests
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
|
Test failures are unrelated (https://github.com/xamarin/maccore/issues/2450, https://github.com/xamarin/maccore/issues/2620). |
#16223. (#16232) Clang will by default emit objc_msgSend stubs in Xcode 14, which ld from earlier Xcodes doesn't understand. We disable this by passing -fno-objc-msgsend-selector-stubs to clang. Ref: https://developer.apple.com/videos/play/wwdc2022/110363/ Ref: https://www.wwdcnotes.com/notes/wwdc22/110363/ Ref: llvm/llvm-project#56034 Fixes #16223. Backport of #16231 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
…16236) Clang will by default emit objc_msgSend stubs in Xcode 14, which ld from earlier Xcodes doesn't understand. We disable this by passing -fno-objc-msgsend-selector-stubs to clang. Ref: https://developer.apple.com/videos/play/wwdc2022/110363/ Ref: https://www.wwdcnotes.com/notes/wwdc22/110363/ Ref: llvm/llvm-project#56034 Fixes #16223. Backport of #16231 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Applies the same fix as xamarin/xamarin-macios#16231. We recently started seeing the same issue in our runtime builds, see dotnet#89925. This is because the AzDO build machines use Xcode 14 but the Helix machines are still using Xcode 13 so linking an Xcode-14-built static library fails. Fixes dotnet#89925
Applies the same fix as xamarin/xamarin-macios#16231. We recently started seeing the same issue in our runtime builds, see #89925. This is because the AzDO build machines use Xcode 14 now but the Helix machines are still using Xcode 13 so linking an Xcode-14-built static library fails. This happens in e.g. libSystem.Native.a or libSystem.Globalization.Native.a (the two libraries where we're using Objective-C). Fixes #89925
Clang will by default emit objc_msgSend stubs in Xcode 14, which ld from
earlier Xcodes doesn't understand. We disable this by passing
-fno-objc-msgsend-selector-stubs to clang.
Ref: https://developer.apple.com/videos/play/wwdc2022/110363/
Ref: https://www.wwdcnotes.com/notes/wwdc22/110363/
Ref: llvm/llvm-project#56034
Fixes #16223.