Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we restore the temp csproj to compute AOT compiler path #16280

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Ensure we restore the temp csproj to compute AOT compiler path #16280

merged 2 commits into from
Oct 7, 2022

Conversation

mauroa
Copy link
Contributor

@mauroa mauroa commented Oct 6, 2022

The build command doesn't support a parameter to specify a NuGet.config, so we need to restore the temp project first, so we pass the NuGet.config file to use the sources from, in case it exists (e.g: the NuGet.config from the XMA dotnet path).

This is useful to support auhtorized NuGet feeds

Fixes Bug #1611102 - [XVS][MAUI] Failed to build .NET MAUI (net6.0) with iOS Simulator: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1611102

@mauroa mauroa added the not-notes-worthy Ignore for release notes label Oct 6, 2022
@mauroa mauroa self-assigned this Oct 6, 2022
@mauroa mauroa marked this pull request as draft October 6, 2022 16:34
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@mauroa mauroa marked this pull request as ready for review October 6, 2022 21:31
@mauroa
Ensure we restore the temp csproj to compute AOT compiler path
0f933ef 
The build command doesn't support a parameter to specify a NuGet.config, so we need to restore the temp project first, so we pass the NuGet.config file to use the sources from, in case it exists (e.g: the NuGet.config from the XMA dotnet path).

This is useful to support auhtorized NuGet feeds
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Tests on macOS M1 - Mac Big Sur (11.5) failed for unknown reasons.

Pipeline on Agent
Hash: 9d249c9ed9f4e8899f3c67e7bd1a269e68b35fa9 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 9d249c9ed9f4e8899f3c67e7bd1a269e68b35fa9 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1043.Monterey'
Hash: 9d249c9ed9f4e8899f3c67e7bd1a269e68b35fa9 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 223 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne rolfbjarne merged commit 6bc66bf into main Oct 7, 2022
@rolfbjarne rolfbjarne deleted the dev/mag/main branch October 7, 2022 06:16
@rolfbjarne
Copy link
Member

/sudo backport release/6.0.4xx

@rolfbjarne
Copy link
Member

/sudo backport release/6.0.4xx-xcode14

@rolfbjarne
Copy link
Member

/sudo backport release/7.0.1xx-rc2

@rolfbjarne
Copy link
Member

/sudo backport release/7.0.1xx-xcode14-rc2

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.4xx Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/6.0.4xx-xcode14 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.1xx-rc2 Created! The magic is happening here

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Backport Job to branch release/7.0.1xx-xcode14-rc2 Created! The magic is happening here

This was referenced Oct 7, 2022
Merged
Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6793810 for more details.

Merged
@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6793812 for more details.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6793813 for more details.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=6793814 for more details.

@rolfbjarne
Copy link
Member

Oh no! Backport failed! Please see devdiv.visualstudio.com/DevDiv/_build/results?buildId=6793810 for more details.

I guess we don't need this on release/6.0.4xx, since that branch is now only producing macOS and Mac Catalyst builds.

rolfbjarne pushed a commit that referenced this pull request Oct 7, 2022
@vs-mobiletools-engineering-service2 @mauroa
[release/7.0.1xx-rc2] Ensure we restore the temp csproj to compute AO…
903a851 
…T compiler path (#16283)

The build command doesn't support a parameter to specify a NuGet.config, so we need to restore the temp project first, so we pass the NuGet.config file to use the sources from, in case it exists (e.g: the NuGet.config from the XMA dotnet path).

This is useful to support auhtorized NuGet feeds

Fixes Bug #1611102 - [XVS][MAUI] Failed to build .NET MAUI (net6.0) with iOS Simulator: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1611102

Backport of #16280

Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com>
rolfbjarne pushed a commit that referenced this pull request Oct 7, 2022
@vs-mobiletools-engineering-service2
[release/7.0.1xx-xcode14-rc2] Ensure we restore the temp csproj to co…
bc89446 
…mpute AOT compiler path (#16284)

The build command doesn't support a parameter to specify a NuGet.config, so we need to restore the temp project first, so we pass the NuGet.config file to use the sources from, in case it exists (e.g: the NuGet.config from the XMA dotnet path).

This is useful to support auhtorized NuGet feeds

Fixes Bug #1611102 - [XVS][MAUI] Failed to build .NET MAUI (net6.0) with iOS Simulator: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1611102

Backport of #16280
rolfbjarne pushed a commit that referenced this pull request Oct 7, 2022
@vs-mobiletools-engineering-service2 @mauroa
[release/6.0.4xx-xcode14] Ensure we restore the temp csproj to comput…
fe3d332 
…e AOT compiler path (#16282)

The build command doesn't support a parameter to specify a NuGet.config,
so we need to restore the temp project first, so we pass the
NuGet.config file to use the sources from, in case it exists (e.g: the
NuGet.config from the XMA dotnet path).

This is useful to support auhtorized NuGet feeds

Fixes Bug #1611102 - [XVS][MAUI] Failed to build .NET MAUI (net6.0) with
iOS Simulator:
https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1611102

Backport of #16280

Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@emaf emaf Awaiting requested review from emaf emaf is a code owner

@chamons chamons Awaiting requested review from chamons

Assignees

@mauroa mauroa

Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauroa @vs-mobiletools-engineering-service2 @rolfbjarne