Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] Add numerous item templates. Fixes #15836. #16287

Merged
merged 4 commits into from
Oct 10, 2022
Merged

[dotnet] Add numerous item templates. Fixes #15836. #16287

merged 4 commits into from
Oct 10, 2022

Conversation

rolfbjarne
Copy link
Member

Add the following item templates for all platforms:

  • Controller (View Controller with UI written in code)
  • View
  • View Controller (View Controller with UI written in XIB)
  • Storyboard

Item templates won't show up in VSMac until this is released:
https://github.com/xamarin/vsmac/pull/9133.

Fixes #15836.

Also update the template tests accordingly.

This PR might be easier to review commit-by-commit due to the large number of generated localization files.

@rolfbjarne
[dotnet] Add numerous item templates. Fixes xamarin#15836.
547df51 
Add the following item templates for all platforms:

* Controller (View Controller with UI written in code)
* View
* View Controller (View Controller with UI written in XIB)
* Storyboard

Item templates won't show up in VSMac until this is released: xamarin/vsmac#9133.

Fixes xamarin#15836.
@rolfbjarne
[tests] Add and update tests for the new templates.
ebdc2a1
@rolfbjarne
[dotnet] Update template localizations.
0e29593
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Oct 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@dalexsoto
Copy link
Member

Go auto format 😀

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: c16ef7044cd42397b4b68d3032375f2706380189 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent XAMBOT-1107.Monterey'
Hash: c16ef7044cd42397b4b68d3032375f2706380189 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: c16ef7044cd42397b4b68d3032375f2706380189 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

0 tests crashed, 1 tests failed, 222 tests passed.

Failures

❌ linker tests

1 tests failed, 64 tests passed.
  • trimmode link/tvOS - simulator/Debug [dotnet]: Failed

Html Report (VSDrops) Download

Successes

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: [PR build]

@rolfbjarne
Copy link
Member Author

Test failure is unrelated (https://github.com/xamarin/maccore/issues/1083).

@rolfbjarne rolfbjarne merged commit acf4edb into xamarin:main Oct 10, 2022
@rolfbjarne rolfbjarne deleted the dotnet-item-templates branch October 10, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tj-devel709 tj-devel709 tj-devel709 approved these changes

@mrward mrward mrward approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

@pjcollins pjcollins Awaiting requested review from pjcollins

@jonathanpeppers jonathanpeppers Awaiting requested review from jonathanpeppers

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[net6/7] Templates for "Add File" feature in VSfM
5 participants
@rolfbjarne @dalexsoto @vs-mobiletools-engineering-service2 @mrward @tj-devel709