Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HealthKit] Add support for Xcode 15 beta 7 #18927

Merged
merged 11 commits into from
Sep 11, 2023
Merged

[HealthKit] Add support for Xcode 15 beta 7 #18927

merged 11 commits into from
Sep 11, 2023

Conversation

haritha-mohan
Copy link
Contributor

Looking into a intro failure on iOS: Selector not found for HealthKit.HKHealthStore : workoutSessionMirroringStartHandler in System.Action`1[HealthKit.HKWorkoutSession] get_WorkoutSessionMirroringStartHandler() on HealthKit.HKHealthStore

haritha-mohan and others added 2 commits September 5, 2023 11:05
@haritha-mohan
[HealthKit] Add support for Xcode 15 beta 7
3ff18d4 
Not ready to merge yet! Looking into a intro failure on iOS:
Selector not found for HealthKit.HKHealthStore : workoutSessionMirroringStartHandler
in System.Action`1[HealthKit.HKWorkoutSession] get_WorkoutSessionMirroringStartHandler() on HealthKit.HKHealthStore
Auto-format source code
e605079
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

mandel-macaque
mandel-macaque requested changes Sep 5, 2023
View reviewed changes
src/HealthKit/Enums.cs Outdated Show resolved Hide resolved
src/HealthKit/Enums.cs Outdated Show resolved Hide resolved
src/HealthKit/Enums.cs Outdated Show resolved Hide resolved
src/HealthKit/Enums.cs Outdated Show resolved Hide resolved
src/healthkit.cs Outdated Show resolved Hide resolved
src/healthkit.cs Outdated Show resolved Hide resolved
src/healthkit.cs Outdated Show resolved Hide resolved
@haritha-mohan @mandel-macaque
Apply suggestions from code review
662e1d9 
Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
@haritha-mohan haritha-mohan marked this pull request as ready for review September 5, 2023 15:50
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
dalexsoto
dalexsoto requested changes Sep 5, 2023
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/healthkit.cs Outdated Show resolved Hide resolved
src/healthkit.cs Outdated Show resolved Hide resolved
src/healthkit.cs Outdated Show resolved Hide resolved
src/healthkit.cs Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@haritha-mohan @dalexsoto
Apply suggestions from code review
49de871 
Co-authored-by: Alex Soto <alex@soto.dev>
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
rolfbjarne
rolfbjarne requested changes Sep 6, 2023
View reviewed changes
src/healthkit.cs Outdated Show resolved Hide resolved
src/healthkit.cs Outdated Show resolved Hide resolved
tj-devel709
tj-devel709 reviewed Sep 6, 2023
View reviewed changes
src/healthkit.cs Outdated Show resolved Hide resolved
tj-devel709
tj-devel709 reviewed Sep 6, 2023
View reviewed changes
src/healthkit.cs Outdated Show resolved Hide resolved
tj-devel709
tj-devel709 requested changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@tj-devel709 tj-devel709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think you may need to add a few Async calls though!

rolfbjarne
rolfbjarne requested changes Sep 7, 2023
View reviewed changes
src/healthkit.cs Outdated Show resolved Hide resolved
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: ad9ac57d3e863d0df0a754f785fc85e314aaee18 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: ad9ac57d3e863d0df0a754f785fc85e314aaee18 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 237 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 13 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 38 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: ad9ac57d3e863d0df0a754f785fc85e314aaee18 [PR build]

@haritha-mohan haritha-mohan merged commit ae6ef4a into xamarin:net8.0-xcode15 Sep 11, 2023
72 of 74 checks passed
@haritha-mohan haritha-mohan deleted the net8.0-xcode15-healthkit branch September 11, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@tj-devel709 tj-devel709 tj-devel709 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@haritha-mohan @vs-mobiletools-engineering-service2 @dalexsoto @rolfbjarne @mandel-macaque @tj-devel709