[Foundation] Add support for Xcode 15 beta 7. #19007

mandel-macaque · 2023-09-12T19:24:30Z

No description provided.

mandel-macaque · 2023-09-12T19:25:50Z

src/Foundation/Enum.cs

+		[Watch (10, 0), TV (17, 0), NoMac, iOS (17, 0), MacCatalyst (17,0)]
+		[Field ("NSFileProtectionCompleteWhenUserInactive")]
+		CompleteWhenUserInactive,


This, is a normal situation, should not be allowed. YET! this enum was never released and was added in #18918 meaning no developer ever has used this enum.

github-actions · 2023-09-12T19:28:52Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

src/foundation.cs

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

dalexsoto

After @rolfbjarne 👍

src/foundation.cs

mandel-macaque · 2023-09-27T23:00:27Z

@rolfbjarne I implemented the requested changes and tests pass.

dalexsoto · 2023-09-28T11:02:44Z

src/Foundation/Enum.cs

+		[Watch (10, 0), TV (17, 0), NoMac, iOS (17, 0), MacCatalyst (17, 0)]
+		[Field ("NSFileProtectionCompleteWhenUserInactive")]
+		CompleteWhenUserInactive,
 		[Field ("NSFileProtectionNone")]
 		None,


There is a breaking change

Suggested change

[Watch (10, 0), TV (17, 0), NoMac, iOS (17, 0), MacCatalyst (17, 0)]

[Field ("NSFileProtectionCompleteWhenUserInactive")]

CompleteWhenUserInactive,

[Field ("NSFileProtectionNone")]

None,

[Field ("NSFileProtectionNone")]

None,

[Watch (10, 0), TV (17, 0), NoMac, iOS (17, 0), MacCatalyst (17, 0)]

[Field ("NSFileProtectionCompleteWhenUserInactive")]

CompleteWhenUserInactive,

rolfbjarne

The PR must be retargeted to main, otherwise this looks good now (except the breaking change Alex mentioned).

src/foundation.cs

vs-mobiletools-engineering-service2 · 2023-10-16T22:21:27Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 3892a70aa1dd39c764f66679a5b4cde361aef0ee [PR build]

vs-mobiletools-engineering-service2 · 2023-10-16T22:25:36Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-16T22:26:29Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-16T22:28:55Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-16T22:42:20Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 3892a70aa1dd39c764f66679a5b4cde361aef0ee [PR build]

vs-mobiletools-engineering-service2 · 2023-10-17T00:36:54Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 3892a70aa1dd39c764f66679a5b4cde361aef0ee [PR build]

mandel-macaque added 2 commits September 12, 2023 13:47

[Foundation] Add support for Xcode 15 beta 7.

cf9a220

Update the binding based on the changes from corespotligh.

bc49111

mandel-macaque requested a review from rolfbjarne as a code owner September 12, 2023 19:24

mandel-macaque commented Sep 12, 2023

View reviewed changes

Auto-format source code

4f10597

This comment has been minimized.

Sign in to view

rolfbjarne requested changes Sep 13, 2023

View reviewed changes

Apply suggestions from code review

f3de459

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Sep 14, 2023

View reviewed changes

tj-devel709 reviewed Sep 19, 2023

View reviewed changes

src/foundation.cs Show resolved Hide resolved

tj-devel709 approved these changes Sep 19, 2023

View reviewed changes

Merge branch 'net8.0-xcode15' into net8.0-xcode15-foundation

29008df

This comment has been minimized.

Sign in to view

mandel-macaque added 2 commits September 27, 2023 10:45

Merge branch 'net8.0-xcode15' into net8.0-xcode15-foundation

2081615

Fix xtro dupes.

d526693

This comment has been minimized.

Sign in to view

dalexsoto requested changes Sep 28, 2023

View reviewed changes

rolfbjarne requested changes Oct 11, 2023

View reviewed changes

src/foundation.cs Show resolved Hide resolved

Merge branch 'main' into net8.0-xcode15-foundation

29fabbf

mandel-macaque requested review from emaf and mauroa as code owners October 16, 2023 20:36

mandel-macaque changed the base branch from net8.0-xcode15 to main October 16, 2023 20:36

mandel-macaque force-pushed the net8.0-xcode15-foundation branch from 076b11c to 19e37d1 Compare October 16, 2023 20:41

Address breaking change.

3892a70

mandel-macaque force-pushed the net8.0-xcode15-foundation branch from 19e37d1 to 3892a70 Compare October 16, 2023 20:50

tj-devel709 approved these changes Oct 16, 2023

View reviewed changes

dustin-wojciechowski approved these changes Oct 16, 2023

View reviewed changes

dalexsoto approved these changes Oct 17, 2023

View reviewed changes

rolfbjarne approved these changes Oct 17, 2023

View reviewed changes

mandel-macaque merged commit b73cb11 into xamarin:main Oct 17, 2023
53 checks passed

mandel-macaque deleted the net8.0-xcode15-foundation branch October 17, 2023 15:27

[Foundation] Add support for Xcode 15 beta 7. #19007

[Foundation] Add support for Xcode 15 beta 7. #19007

Conversation

mandel-macaque commented Sep 12, 2023

mandel-macaque Sep 12, 2023

Choose a reason for hiding this comment

github-actions bot commented Sep 12, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

dalexsoto left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mandel-macaque commented Sep 27, 2023

dalexsoto Sep 28, 2023

Choose a reason for hiding this comment

rolfbjarne left a comment

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Oct 16, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Oct 16, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Oct 16, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Oct 16, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Oct 16, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Oct 17, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts