[Vision] Add support for Xcode 15 #19099

haritha-mohan · 2023-09-25T19:32:11Z

No description provided.

haritha-mohan · 2023-09-25T19:33:58Z

src/vision.cs

+		[return: NullAllowed]
+		NSDictionary<NSString, NSArray<IMLComputeDeviceProtocol>> GetSupportedComputeDevices([NullAllowed] out NSError error);
+
+		// could this be combined into a Get/Set pair? docs are a bit weird..


You would need to use an indexer, since it takes the computeStage: https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/indexers/

And indexers do not have names, so you won't be able to diff with another indexer that takes a string. Leaving it in two diff methods is a better approach.

github-actions · 2023-09-25T19:38:13Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

mandel-macaque

We should add two api when working with smart enums, one that takes an NSString and the other one that takes the enum . The reason is that we want to expose the nicer apit with the enum and also allow a user to pass a value we might have forgotten.

src/vision.cs

mandel-macaque · 2023-09-25T19:41:08Z

src/vision.cs

+		[return: NullAllowed]
+		NSDictionary<NSString, NSArray<IMLComputeDeviceProtocol>> GetSupportedComputeDevices([NullAllowed] out NSError error);
+
+		// could this be combined into a Get/Set pair? docs are a bit weird..


You would need to use an indexer, since it takes the computeStage: https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/indexers/

And indexers do not have names, so you won't be able to diff with another indexer that takes a string. Leaving it in two diff methods is a better approach.

mandel-macaque · 2023-09-25T19:42:13Z

src/vision.cs

+
+		[TV(17, 0), Mac(14, 0), iOS(17, 0), MacCatalyst(17,0)]
+		[Export("supportedJointsGroupNamesAndReturnError:")]
+		[return: NullAllowed]
+		string[] GetSupportedJointsGroupNames([NullAllowed] out NSError error);


Objc returns a string, but is in reality an enum form the one you created: VNAnimalBodyPoseObservationJointsGroupName

discussed offline with @mandel-macaque and decided to follow what was already being done in the framework and use the BindAs attribute to improve the exposed api

src/vision.cs

github-actions · 2023-09-25T21:48:29Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

src/vision.cs

dalexsoto · 2023-09-26T13:15:11Z

src/vision.cs

+		}
+
+		[Export ("parentJoint")]
+		string ParentJoint { get; }


We should look at the docs, this sounds like one of the smart enums if not probably NSString is a better choice here.

Suggested change

string ParentJoint { get; }

NSString ParentJoint { get; }

Agreed, should be a smart enum if possible.

@dalexsoto @mandel-macaque yep good catch, it does return the enum https://developer.apple.com/documentation/vision/vnhumanbodyrecognizedpoint3d/4173215-parentjoint?language=objc

src/vision.cs

Co-authored-by: Alex Soto <alex@soto.dev>

src/vision.cs

vs-mobiletools-engineering-service2 · 2023-10-26T18:11:19Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: c8315524a1eeedf34713a83c6fe91fec86cb8228 [PR build]

vs-mobiletools-engineering-service2 · 2023-10-26T18:18:22Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-26T18:29:49Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
~~watchOS~~ (no change detected)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: c8315524a1eeedf34713a83c6fe91fec86cb8228 [PR build]

vs-mobiletools-engineering-service2 · 2023-10-26T18:35:22Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-26T18:37:36Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-26T20:20:36Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c8315524a1eeedf34713a83c6fe91fec86cb8228 [PR build]

[Vision] Add support for Xcode 15

aac845b

haritha-mohan requested a review from dalexsoto as a code owner September 25, 2023 19:32

haritha-mohan commented Sep 25, 2023

View reviewed changes

Auto-format source code

f01d236

mandel-macaque requested changes Sep 25, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

haritha-mohan and others added 3 commits September 25, 2023 14:43

address review, improve api signature to expose enum type

72e0157

Merge branch 'net8.0-xcode15' into net8.0-xcode15-vision

dd06e6f

Auto-format source code

b97de37

This comment has been minimized.

Sign in to view

dalexsoto requested changes Sep 26, 2023

View reviewed changes

haritha-mohan commented Sep 26, 2023

View reviewed changes

src/vision.cs Outdated Show resolved Hide resolved

Apply suggestions from code review

c9c5fbf

Co-authored-by: Alex Soto <alex@soto.dev>

haritha-mohan commented Sep 26, 2023

View reviewed changes

src/vision.cs Outdated Show resolved Hide resolved

haritha-mohan added 3 commits September 26, 2023 14:23

more straightforward..

9cb3e30

Merge branch 'net8.0-xcode15' into net8.0-xcode15-vision

2e92291

no availbility attrs for error codes

c4c6c10

This comment has been minimized.

Sign in to view

Merge branch 'main' into net8.0-xcode15-vision

c538860

This comment has been minimized.

Sign in to view

Merge branch 'main' into net8.0-xcode15-vision

48bba91

This comment has been minimized.

Sign in to view

Merge branch 'main' into net8.0-xcode15-vision

c831552

rolfbjarne approved these changes Oct 27, 2023

View reviewed changes

dalexsoto approved these changes Oct 31, 2023

View reviewed changes

mandel-macaque approved these changes Oct 31, 2023

View reviewed changes

haritha-mohan merged commit 8908fa1 into xamarin:main Oct 31, 2023
53 checks passed

haritha-mohan deleted the net8.0-xcode15-vision branch October 31, 2023 20:21

[Vision] Add support for Xcode 15 #19099

[Vision] Add support for Xcode 15 #19099

Conversation

haritha-mohan commented Sep 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 25, 2023

⚠️ Your code has been reformatted. ⚠️

mandel-macaque left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Sep 25, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Oct 26, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Oct 26, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Oct 26, 2023

✅ API diff for current PR / commit

❗ API diff vs stable (Breaking changes)

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Oct 26, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Oct 26, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Oct 26, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts