[UIKit] Add support for Xcode 15. #19120

mandel-macaque · 2023-10-02T21:37:09Z

No description provided.

github-actions · 2023-10-02T21:41:38Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

src/UIKit/UIEnums.cs

src/uikit.cs

haritha-mohan · 2023-10-02T23:31:08Z

src/uikit.cs

+	[NoWatch, NoTV, iOS (17, 0), MacCatalyst (17, 0)]
+	[Protocol]
+	interface UIShapeProvider {


iirc protocols need both model and base type attributes?

Suggested change

[NoWatch, NoTV, iOS (17, 0), MacCatalyst (17, 0)]

[Protocol]

interface UIShapeProvider {

[NoWatch, NoTV, iOS (17, 0), MacCatalyst (17, 0)]

#if NET

[Protocol, Model]

#else

[Protocol, Model (AutoGeneratedName = true)]

#endif

[BaseType (typeof (NSObject))]

interface UIShapeProvider {

This is incorrect, from our documentation and from the code generated by sharpie:

/* Check whether adding [Model] to this declaration is appropriate. [Model] is used to generate a C# class that implements this protocol, and might be useful for protocols that consumers are supposed to implement, since consumers can subclass the generated class instead of implementing the generated interface. If consumers are not supposed to implement this protocol, then [Model] is redundant and will generate code that will never be used. */

If you look at the documentation, this is not an interface that has to be implemented by the user https://developer.apple.com/documentation/uikit/uishapeprovider as opposed to the NSUelSession delegate: https://developer.apple.com/documentation/foundation/nsurlsessiondelegate

If you look closer to the API you'll see that the UIShape is the one that returns a UIShapeProvider and users are probably not going to implement this.

haritha-mohan · 2023-10-02T23:36:08Z

src/uikit.cs

+	interface IUITextCursorView { }
+
+	[NoWatch, TV (17, 0), iOS (17, 0), MacCatalyst (17, 0)]
+	[Protocol]


missing base type/model?

Same, this is not going to be implemented by users as opposed to the UITextSelectionDisplayInteractionDelegate which does contain Model in it.

haritha-mohan · 2023-10-02T23:36:15Z

src/uikit.cs

+	interface IUITextSelectionHighlightView { }
+
+	[NoWatch, TV (17, 0), iOS (17, 0), MacCatalyst (17, 0)]
+	[Protocol]


missing base type/model?

This one looks that has to be added as model.

haritha-mohan · 2023-10-02T23:36:22Z

src/uikit.cs

+	interface IUITextSelectionHandleView { }
+
+	[NoWatch, TV (17, 0), iOS (17, 0), MacCatalyst (17, 0)]
+	[Protocol]


there's a few more below that need to be addressed

github-actions · 2023-10-03T17:21:50Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

tests/xtro-sharpie/api-annotations-dotnet/iOS-UIKit.ignore

tj-devel709

Only spotted a really tiny typo but other than that LGTM

src/uikit.cs

vs-mobiletools-engineering-service2 · 2023-10-25T13:58:52Z

❌ [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed ❌

Failed tests are:

introspection

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-25T14:04:06Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-25T14:05:34Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 7ba5234c1e3dfea014562c3c5948411b9c1dfe7e [PR build]

vs-mobiletools-engineering-service2 · 2023-10-25T14:13:46Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-25T14:28:26Z

❗ API diff for current PR / commit (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
~~macOS~~ (no change detected)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
~~macOS~~: (empty diff detected)

❗ API diff vs stable (Breaking changes)

Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)

iOS: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 7ba5234c1e3dfea014562c3c5948411b9c1dfe7e [PR build]

vs-mobiletools-engineering-service2 · 2023-10-25T16:27:27Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 7ba5234c1e3dfea014562c3c5948411b9c1dfe7e [PR build]

mandel-macaque · 2023-10-25T16:41:34Z

/sudo backport release/8.0.xx

vs-mobiletools-engineering-service2 · 2023-10-25T16:42:08Z

Backport Job to branch release/8.0.xx Created! The magic is happening here

mandel-macaque · 2023-10-25T18:24:50Z

/sudo backport release/8.0.1xx

vs-mobiletools-engineering-service2 · 2023-10-25T18:25:23Z

Backport Job to branch release/8.0.1xx Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-10-25T18:27:00Z

Hooray! Backport succeeded! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8592909 for more details.

Backport of #19120 --------- Co-authored-by: Manuel de la Pena <mandel@microsoft.com> Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com> Co-authored-by: Haritha Mohan <harithamohan@microsoft.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>

mandel-macaque requested review from dalexsoto and rolfbjarne as code owners October 2, 2023 21:37