[WebKit] Add support for Xcode 15 #19237

haritha-mohan · 2023-10-17T16:28:25Z

No description provided.

tests/xtro-sharpie/macOS-WebKit.ignore

github-actions · 2023-10-17T16:34:30Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

tests/xtro-sharpie/api-annotations-dotnet/macOS-WebKit.ignore

src/webkit.cs

tests/xtro-sharpie/macOS-WebKit.ignore

rolfbjarne · 2023-10-18T06:22:13Z

tests/xtro-sharpie/api-annotations-dotnet/macOS-WebKit.ignore

+!missing-selector! WKWebView::goBack: not bound
+!missing-selector! WKWebView::goForward: not bound
+!missing-selector! WKWebView::reload: not bound
+!missing-selector! WKWebView::reloadFromOrigin: not bound
+!missing-selector! WKWebView::stopLoading: not bound


I think xtro is right...

The first four show up here (although goBack: and goForward: are commented out)

xamarin-macios/src/webkit.cs

Lines 2888 to 2904 in 17523c3

[Export ("reload:")]

void Reload (NSObject sender);

[Export ("reloadFromOrigin:")]

void ReloadFromOrigin (NSObject sender);

[Export ("canGoBack")]

bool CanGoBack ();

//[Export ("goBack:")]

//void GoBack (NSObject sender);

[Export ("canGoForward")]

bool CanGoForward ();

//[Export ("goForward:")]

//void GoForward (NSObject sender);

but it's for the WebView type, not WKWebView.

xamarin-macios/src/webkit.cs

Line 2701 in 17523c3

partial interface WebView : NSUserInterfaceValidations {

The last one (stopLoading:) doesn't seem to be bound in any type, not even the wrong one.

@rolfbjarne ah good catch, addressed! got confused by the selectors already present in WKWebView with the same name but without the ending ":"

github-actions · 2023-10-18T18:45:19Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

mandel-macaque · 2023-10-18T20:20:22Z

tests/xtro-sharpie/api-annotations-dotnet/common-WebKit.ignore

+# xcode 15
+# requires OS_nw_proxy_config type which has not been bound yet, part of Xcode 15 Network binding
+!missing-selector! WKWebsiteDataStore::proxyConfigurations not bound
+!missing-selector! WKWebsiteDataStore::setProxyConfigurations: not bound


@haritha-mohan can you please create an issue to track this, I'll take care of it once I do the network framework.

👍 #19259

vs-mobiletools-engineering-service2 · 2023-10-18T21:00:54Z

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 3c7425e62459a660e2d642a4293db41dbd8098ce [PR build]

vs-mobiletools-engineering-service2 · 2023-10-18T21:09:18Z

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-18T21:10:47Z

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-18T21:20:19Z

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

vs-mobiletools-engineering-service2 · 2023-10-18T21:23:04Z

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
~~tvOS~~ (no change detected)
~~watchOS~~ (no change detected)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
~~tvOS~~: (empty diff detected)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
watchOS: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

iOS: vsdrops gist (No breaking changes)
tvOS: vsdrops gist (No breaking changes)
MacCatalyst: vsdrops gist (No breaking changes)
macOS: vsdrops gist (No breaking changes)
Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

iOS: vsdrops gist
tvOS: vsdrops gist
macOS: vsdrops gist

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 3c7425e62459a660e2d642a4293db41dbd8098ce [PR build]

vs-mobiletools-engineering-service2 · 2023-10-19T01:05:57Z

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 235 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 41 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 3c7425e62459a660e2d642a4293db41dbd8098ce [PR build]

haritha-mohan · 2023-10-19T16:03:54Z

/sudo backport release/8.0.xx

vs-mobiletools-engineering-service2 · 2023-10-19T16:04:36Z

Backport Job to branch release/8.0.xx Created! The magic is happening here

dalexsoto · 2023-10-19T16:29:13Z

/sudo backport release/8.0.1xx

vs-mobiletools-engineering-service2 · 2023-10-19T16:29:50Z

Backport Job to branch release/8.0.1xx Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-10-19T16:31:45Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8563239 for more details.

haritha-mohan · 2023-10-19T16:39:37Z

/sudo backport release/8.0.1xx

vs-mobiletools-engineering-service2 · 2023-10-19T16:40:12Z

Backport Job to branch release/8.0.1xx Created! The magic is happening here

vs-mobiletools-engineering-service2 · 2023-10-19T16:42:35Z

Oh no! Backport failed! Please see https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8563293 for more details.

[WebKit] Add support for Xcode 15

8989ce9

haritha-mohan commented Oct 17, 2023

View reviewed changes

tests/xtro-sharpie/macOS-WebKit.ignore Show resolved Hide resolved

tests/xtro-sharpie/macOS-WebKit.ignore Show resolved Hide resolved

Auto-format source code

e182f53

tj-devel709 reviewed Oct 17, 2023

View reviewed changes

tests/xtro-sharpie/api-annotations-dotnet/macOS-WebKit.ignore Outdated Show resolved Hide resolved

tj-devel709 approved these changes Oct 17, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

haritha-mohan commented Oct 18, 2023

View reviewed changes

src/webkit.cs Outdated Show resolved Hide resolved

fix cecil test failure

7977a45

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Oct 18, 2023

View reviewed changes

dalexsoto approved these changes Oct 18, 2023

View reviewed changes

haritha-mohan and others added 2 commits October 18, 2023 11:36

add WKWebView bindings

3337027

Auto-format source code

3c7425e

mandel-macaque approved these changes Oct 18, 2023

View reviewed changes

haritha-mohan mentioned this pull request Oct 18, 2023

[Xcode15] Add missing binding in WebKit #19259

Closed

rolfbjarne approved these changes Oct 19, 2023

View reviewed changes

haritha-mohan merged commit 703bcfc into xamarin:main Oct 19, 2023
49 checks passed

haritha-mohan deleted the net8.0-xcode15-webkit branch October 19, 2023 16:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WebKit] Add support for Xcode 15 #19237

[WebKit] Add support for Xcode 15 #19237

haritha-mohan commented Oct 17, 2023

github-actions bot commented Oct 17, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Oct 18, 2023

haritha-mohan Oct 18, 2023

github-actions bot commented Oct 18, 2023

mandel-macaque Oct 18, 2023

haritha-mohan Oct 18, 2023

vs-mobiletools-engineering-service2 commented Oct 18, 2023

vs-mobiletools-engineering-service2 commented Oct 18, 2023

vs-mobiletools-engineering-service2 commented Oct 18, 2023

vs-mobiletools-engineering-service2 commented Oct 18, 2023

vs-mobiletools-engineering-service2 commented Oct 18, 2023

vs-mobiletools-engineering-service2 commented Oct 19, 2023

haritha-mohan commented Oct 19, 2023

vs-mobiletools-engineering-service2 commented Oct 19, 2023

dalexsoto commented Oct 19, 2023

vs-mobiletools-engineering-service2 commented Oct 19, 2023

vs-mobiletools-engineering-service2 commented Oct 19, 2023

haritha-mohan commented Oct 19, 2023

vs-mobiletools-engineering-service2 commented Oct 19, 2023

vs-mobiletools-engineering-service2 commented Oct 19, 2023

	[Export ("reload:")]
	void Reload (NSObject sender);

	[Export ("reloadFromOrigin:")]
	void ReloadFromOrigin (NSObject sender);

	[Export ("canGoBack")]
	bool CanGoBack ();

	//[Export ("goBack:")]
	//void GoBack (NSObject sender);

	[Export ("canGoForward")]
	bool CanGoForward ();

	//[Export ("goForward:")]
	//void GoForward (NSObject sender);

[WebKit] Add support for Xcode 15 #19237

[WebKit] Add support for Xcode 15 #19237

Conversation

haritha-mohan commented Oct 17, 2023

github-actions bot commented Oct 17, 2023

⚠️ Your code has been reformatted. ⚠️

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne Oct 18, 2023

Choose a reason for hiding this comment

haritha-mohan Oct 18, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 18, 2023

⚠️ Your code has been reformatted. ⚠️

mandel-macaque Oct 18, 2023

Choose a reason for hiding this comment

haritha-mohan Oct 18, 2023

Choose a reason for hiding this comment

vs-mobiletools-engineering-service2 commented Oct 18, 2023

💻 [CI Build] Windows Integration Tests passed 💻

vs-mobiletools-engineering-service2 commented Oct 18, 2023

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

vs-mobiletools-engineering-service2 commented Oct 18, 2023

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

vs-mobiletools-engineering-service2 commented Oct 18, 2023

📚 [PR Build] Artifacts 📚

Packages generated

vs-mobiletools-engineering-service2 commented Oct 18, 2023

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

vs-mobiletools-engineering-service2 commented Oct 19, 2023

🚀 [CI Build] Test results 🚀

Test results

Tests counts

haritha-mohan commented Oct 19, 2023

vs-mobiletools-engineering-service2 commented Oct 19, 2023

dalexsoto commented Oct 19, 2023

vs-mobiletools-engineering-service2 commented Oct 19, 2023

vs-mobiletools-engineering-service2 commented Oct 19, 2023

haritha-mohan commented Oct 19, 2023

vs-mobiletools-engineering-service2 commented Oct 19, 2023

vs-mobiletools-engineering-service2 commented Oct 19, 2023