-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Start moving to parse the configuration of the build in the tests pipelines #21009
Conversation
This comment has been minimized.
This comment has been minimized.
tools/devops/automation/templates/common/load_configuration.yml
Outdated
Show resolved
Hide resolved
- bash: ./xamarin-macios/tools/devops/automation/scripts/bash/configure-platforms.sh | ||
name: configure_platforms | ||
displayName: 'Configure platforms' | ||
|
||
- pwsh: | | ||
Import-Module $Env:SYSTEM_DEFAULTWORKINGDIRECTORY/xamarin-macios/tools/devops/automation/scripts/MaciosCI.psd1 | ||
$jsonPath = Join-Path -Path "$(Build.ArtifactStagingDirectory)" -ChildPath "configuration.json" | ||
Write-Host "##vso[task.setvariable variable=CONFIG_PATH]$jsonPath" | ||
New-BuildConfiguration -ConfigFile $jsonPath | ||
env: | ||
GITHUB_TOKEN: $(GitHub.Token) | ||
ACCESSTOKEN: $(AzDoBuildAccess.Token) | ||
name: labels | ||
displayName: 'Configure build' | ||
|
||
- bash: ./xamarin-macios/tools/devops/automation/scripts/bash/configure-decisions.sh | ||
name: decisions | ||
displayName: 'Make decisions' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a copy of configure.yml, and seems to create (and later upload) configuration.xml like configure.yml does. Isn't this file supposed to load the already created configuration.xml instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a copy, the idea is that I'll be making changes one by one to keep the compatibility and remove those steps that are not needed. ATM we are loading the test matrix from the config, yet we are generating the config. That will be the next step.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
📚 [CI Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)
✅ API diff vs stable.NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
❌ [CI Build] Windows Integration Tests failed ❌❌ Failed ❌ Pipeline on Agent |
🔥 [CI Build] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 1 tests failed, 97 tests passed. Failures❌ dotnettests tests (MacCatalyst) [attempt 2]
Html Report (VSDrops) Download Successes✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
❌ [CI Build] Windows Integration Tests failed ❌❌ Failed ❌ Pipeline on Agent |
The pwsh used on windows is based on dotnet framework. Dotnet framework has a limit in the size of the env that can be passed to a child process. We are very close to reach the limit, but after #21009 we can ignore that env variable since it is parsed from the args. This is just needed for the ci pipeline because the issues are going to have are related with the vsdrops task used to upload nuget results etc..
The pwsh used on windows is based on dotnet framework. Dotnet framework has a limit in the size of the env that can be passed to a child process. We are very close to reach the limit, but after #21009 we can ignore that env variable since it is parsed from the args. This is just needed for the ci pipeline because the issues are going to have are related with the vsdrops task used to upload nuget results etc..
At the moment we are recaculating the configuration that was used in the build to decide which tests to run, that is not needed since the configuration was uploaded to the artifacts.
This change will allow to do the following: