[net9.0] Merge main into net9.0. #21179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory properties public. (#21074) When VS (Windows) needs to figure out where the iOS SDK is located on disk on the Mac machine, the project is evaluated and the`_XamarinRelativeSdkRootDirectory` property is read. Unfortunately an MSBuild optimization recently occurred in VS, where they don't keep underscored properties around after the build, and thus the property XVS needs to inspect isn't there anymore. So make `_XamarinRelativeSdkRootDirectory` and `_RelativeMlaunchPath` public properties by removing the underscore. Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2220369.
…'. (#21095) This way the dependency is automatically bumped and we're not left in the stone age.
Looking at the package explorer for recent .NET 9 preview 7 builds I noticed that other packages do not include sha metadata in the version element. Compare the following by clicking "View Metadata source": https://nuget.info/packages/Microsoft.iOS.Ref.net9.0_17.5/17.5.9231-net9-p7 https://nuget.info/packages/Microsoft.NETCore.App.Runtime.Mono.ios-arm64/9.0.0-preview.7.24405.7 https://nuget.info/packages/Microsoft.Maui.Sdk/9.0.0-preview.7.24407.4 The sha metadata inclusion in the version element but not the .nupkg name also causes conflicts with the latest version of the [arcade publishing tooling][0] which expects these to be in sync. While waiting for a fix in arcade, we can remove this metadata to restore dependency flow. It can be restored in the future by setting the following: NUGET_BUILD_METADATA=+sha.$(CURRENT_HASH) The icon and other package metadata have been updated to better match other .NET packages. [0]: https://github.com/dotnet/arcade/blob/b4f4d40741f161e2c0d96c19c51a4013850ef65f/src/Microsoft.DotNet.Build.Tasks.Feed/src/PushToBuildStorage.cs --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
… for it. (#21104) Autotools was required to build mono from source, which we haven't done in a *long* time.
…file. (#21084) Hopefully this fixes an issue rerunning the api diff, where uploading the change-detection.zip file would fail because it already exists in the artifact.
BRANCH_NAME is the variable Jenkins used, so add support for the variable Azure DevOps uses (BUILD_SOURCEBRANCH). Backport of #21114 --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
This pull request updates the following dependencies ## From https://github.com/dotnet/xharness - **Subscription**: 601bc5e1-1cae-44b5-cf5f-08db9342aa2f - **Build**: 20240820.3 - **Date Produced**: August 20, 2024 8:52:49 AM UTC - **Commit**: 69f15217657bc3a7f0102911aa967525529fdfdb - **Branch**: refs/heads/main - **Updates**: - **Microsoft.DotNet.XHarness.iOS.Shared**: [from 9.0.0-prerelease.24405.1 to 9.0.0-prerelease.24420.3][1] [1]: dotnet/xharness@9794254...69f1521
…d their underlying native enum type. (#21089) This will be helpful for some new Xcode 16 APIs.
This pull request updates the following dependencies ## From https://github.com/dotnet/installer - **Subscription**: 80cb9ffd-f92f-4fc8-9f8b-08dbca46abfb - **Build**: 20240819.10 - **Date Produced**: August 19, 2024 9:04:53 PM UTC - **Commit**: 6e9002c2efcfc09687feca31864ebc987c3c9ec8 - **Branch**: refs/heads/release/8.0.1xx - **Updates**: - **Microsoft.Dotnet.Sdk.Internal**: [from 8.0.109-servicing.24416.1 to 8.0.109-servicing.24419.10][8] [8]: dotnet/installer@2284398...6e9002c ## Coherency Updates The following updates ensure that dependencies with a *CoherentParentDependency* attribute were produced in a build used as input to the parent dependency's build. See [Dependency Description Format](https://github.com/dotnet/arcade/blob/master/Documentation/DependencyDescriptionFormat.md#dependency-description-overview) - **Coherency Updates**: - **Microsoft.NET.ILLink.Tasks**: from 8.0.7 to 8.0.8 (parent: Microsoft.Dotnet.Sdk.Internal) - **Microsoft.AspNetCore.App.Ref**: from 8.0.7 to 8.0.8 (parent: Microsoft.Dotnet.Sdk.Internal) - **Microsoft.NETCore.App.Ref**: from 8.0.7 to 8.0.8 (parent: Microsoft.Dotnet.Sdk.Internal) - **Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100**: from 8.0.7 to 8.0.8 (parent: Microsoft.NETCore.App.Ref) - **Microsoft.NETCore.App.Ref**: from 8.0.7 to 8.0.8 (parent: Microsoft.Dotnet.Sdk.Internal)
…t instead of as CI jobs. (#21120)
We want to be able to export and load the variables in the cacading pipelines. The way we have the scripts makes this process very complicated to do. We need to clean up the script. Then export the steps so that we can access them in the following pipelines. This change is simply refactoring the way we load/export the default VSTS variables in a pipeline. --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
…I. (#21122) We're seeing random failures during workload installations in CI, so increase the default verbosity to see if we can get an idea of what's happening.
Before PR: NSUrlSessionHandler.Proxy property throws NSE when client code set any value (including `null`):  After PR NSUrlSessionHandler.Proxy property throws NSE only when the client code tries to set a value different from `null` (Custom proxy is not supported right now in iOS implementation so setting a value other than null must throws NSE):  Fixes #21132. PR originally submitted by @adospace in #21137. Co-authored-by: adospace <adospace@msn.com>
…values. (#21110) Also a few other misc API improvements.
…ases. (#21135) * Forward [Obsolete] from api definition interfaces. * Generate [EditorBrowsable] whenever an api definition member as either [EditorBrowsable] or [Obsolete].
…ces if we're registering protocols in the static registrar. (#21012) When we implemented support for using default interface members for binding protocols, we also unintentionally introduced a size regression. This happened because we now tell the linker to keep all methods in a protocol interface, thus all the corresponding types end up marked as well, etc. This had an additional side effect: depending on the types that weren't linked away anymore, the App Store could flag an app, saying that additional entitlements is needed. This is what's happening in #21002: the App Store detects that the app references the `application:didRegisterForRemoteNotificationsWithDeviceToken:` selector [1] (from the method `RegisteredForRemoteNotifications` on `IUIApplicationDelegate`) and tells the developer they probably need the push notification entitlement. The good news is that we don't need these protocol interface methods at runtime if the optimization to register protocols with the static registrar is enabled (which it is by default). In this PR I teach the optimizer to remove the DynamicDependency attributes keeping these protocol interface methods from being trimmed out. ## Size improvements * monotouch-test build for Release/ios-arm64 shrinks by [2.9mb (-2.6%)](https://gist.github.com/rolfbjarne/5e8ca6ea6854dc4a46f8e838dff11e6b) * A very simple app (tests/dotnet/MySimpleApp) shrinks by [176kb (-0.3%)](https://gist.github.com/rolfbjarne/f0e062900528eb499fd96d124d18376f) [1]: This is somewhat speculative, but it's probably not far from what the App Store actually does. Fixes #21002.
Keep working towards simplifying the configuration script.
…ght away. (#21027) This way execution won't stop if the warning was turned into an error, and we'll get a list of all the warnings by executing once, instead of having to re-execute after fixing each warning.
rolfbjarne
requested review from
mandel-macaque and
dalexsoto
as code owners
We are tryihng to sort out all the scripts to make it re-usable in order to use them in cascading pipelines. --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
This comment has been minimized.
This comment has been minimized.
haritha-mohan
approved these changes
Sep 4, 2024
dalexsoto
approved these changes
Sep 4, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The 'nw_connection_set_viability_changed_handler' P/Invoke was originally bound as 'SetBooleanChangeHandler', which isn't quite right. So now bind it as 'SetViabilityChangeHandler', obsolete the old version and remove it in XAMCORE_5_0.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
It's no longer supported.
…-net9.0-2024-09-04
📚 [CI Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 100 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.