Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Foundation] NSUrlSessionHandler: Adds support for X509 client certificates #21284

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

[Foundation] NSUrlSessionHandler: Adds support for X509 client certificates #21284

wants to merge 16 commits into from
+213 −11

Commits on Sep 23, 2024

  1. Adds support for X509 client certificates

    @rolfbjarne
    Morten Nielsen authored and rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    1325e7a View commit details
    Browse the repository at this point in the history

  2. Add certicate helper from .NET Runtime repro

    @dotMorten @rolfbjarne
    dotMorten authored and rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f443251 View commit details
    Browse the repository at this point in the history

  3. Move certificate helper in as a private local class

    @dotMorten @rolfbjarne
    dotMorten authored and rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    257dfdb View commit details
    Browse the repository at this point in the history

  4. Fully qualify type

    @dotMorten @rolfbjarne
    dotMorten authored and rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    636031e View commit details
    Browse the repository at this point in the history

  5. Only include new functionality for NET builds

    @dotMorten @rolfbjarne
    dotMorten authored and rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f34ded9 View commit details
    Browse the repository at this point in the history

  6. Fix code formatting

    @dotMorten @rolfbjarne
    dotMorten authored and rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c7b65b4 View commit details
    Browse the repository at this point in the history

  7. Add unit test

    @dotMorten @rolfbjarne
    dotMorten authored and rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a8886c0 View commit details
    Browse the repository at this point in the history

  8. Fix tests on macOS by not using the default keyset of the system by a… 

    …n in memory one (EphemeralKeySet).
    @mandel-macaque @rolfbjarne
    mandel-macaque authored and rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ee2d96e View commit details
    Browse the repository at this point in the history

  9. Move to exportable to fix the tests.

    @mandel-macaque @rolfbjarne
    mandel-macaque authored and rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2bef14f View commit details
    Browse the repository at this point in the history

  10. Add the persistent storage.

    @mandel-macaque @rolfbjarne
    mandel-macaque authored and rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    56a0758 View commit details
    Browse the repository at this point in the history

  11. Add documentation.

    @rolfbjarne
    rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2583158 View commit details
    Browse the repository at this point in the history

  12. Seems to be that just adding exportable is enough.

    @mandel-macaque @rolfbjarne
    mandel-macaque authored and rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    30d46f9 View commit details
    Browse the repository at this point in the history

  13. Use platform-specific x509 flags, macOS isn't like other platforms.

    @rolfbjarne
    rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9d0e5c5 View commit details
    Browse the repository at this point in the history

  14. Use temporary keychain when importing PKCS#12 data into a SecIdentity… 

    … on macOS 15+.
    @rolfbjarne
    rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2d43afd View commit details
    Browse the repository at this point in the history

  15. Don't run new test on macOS 14 or earlier.

    @rolfbjarne
    rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    70e4b16 View commit details
    Browse the repository at this point in the history

  16. Update cecil tests.

    @rolfbjarne
    rolfbjarne committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    878218f View commit details
    Browse the repository at this point in the history