Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cecil-tests] Add two more tests. #21625

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[cecil-tests] Add two more tests. #21625

merged 1 commit into from
Nov 18, 2024

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Nov 14, 2024 •
edited
Loading

Add two more Cecil tests:

  • Verify that we don't call the NSObject.Handle setter, we're supposed to call
    NSObject.InitializeHandle instead (which throws an exception if the handle
    is null),
  • Verify that we never call the base class' default constructor (very easy
    mistake to make) in manually bound constructors - we're supposed to call the
    overload that takes an NSObjectFlag parameter instead.

@rolfbjarne
[cecil-tests] Add two more tests.
0d9947a 
Add two more Cecil tests:

* Verify that we don't call the NSObject.Handle setter, we're supposed to call
  NSObject.InitializeHandle instead (which throws an exception if the handle
  is null),
* Verify that we never call the base class' default constructor (very easy
  mistake to make) in manually bound constructors - we're supposed to call the
  overload that takes an `NSObjectFlag` paramater instead.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 0d9947adfc289b873bdb89a1deb31eeff2ac05f8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET (No breaking changes)

✅ API diff vs stable

.NET (No breaking changes)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 0d9947adfc289b873bdb89a1deb31eeff2ac05f8 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 0d9947adfc289b873bdb89a1deb31eeff2ac05f8 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 0d9947adfc289b873bdb89a1deb31eeff2ac05f8 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 0d9947adfc289b873bdb89a1deb31eeff2ac05f8 [PR build]

@rolfbjarne rolfbjarne marked this pull request as ready for review November 15, 2024 15:54
@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 101 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 3 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 40 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 7 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 7 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 0d9947adfc289b873bdb89a1deb31eeff2ac05f8 [PR build]

stephen-hawley
stephen-hawley approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@stephen-hawley stephen-hawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some really great tests. I especially like the one that checks for only throwing

@rolfbjarne rolfbjarne merged commit 98bee4d into main Nov 18, 2024
17 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/tests-add-cecil-tests branch November 18, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-hawley stephen-hawley stephen-hawley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @stephen-hawley