[homekit] Update for Xcode 9 beta 1 & 2 #2276

VincentDondain · 2017-06-30T01:33:27Z

Reviewed iOS/watchOS/tvOS API diffs for beta 1 & 2.

spouliot · 2017-06-30T02:04:17Z

src/HomeKit/HMMutablePresenceEvent.cs

+
+ partial class HMMutablePresenceEvent {
+
+ public HMPresenceType PresenceType {


make it virtual so we can replace this with normal bindings (once support is added to the generator)

Mmh sure but I don't follow the logic. Why is virtual needed? Wound't we just remove the manual bindings?

Because BindAs will generate a virtual member so making it virtual will be a breaking change, also we will need to use the same property name too so it is also not a breaking change

Right to avoid a breaking change, fair enough. However that is in the eventuality the generator fix doesn't make it before our release of the Xcode 9 APIs right? We can break before that.

yup we can break before it becomes stable, but we can keep the binary compat since now :)

spouliot · 2017-06-30T02:04:27Z

src/HomeKit/HMMutableSignificantTimeEvent.cs

+
+ partial class HMMutableSignificantTimeEvent {
+
+ public HMSignificantEvent SignificantEvent {


spouliot · 2017-06-30T02:07:18Z

src/homekit.cs

@@ -1227,7 +1326,7 @@ interface HMHomeAccessControl {
 [TV (10,0)]
 [BaseType (typeof (HMEvent))]
 [DisableDefaultCtor]
- interface HMLocationEvent : NSMutableCopying {
+ interface HMLocationEvent : NSCopying, NSMutableCopying {


unneeded since NSMutableCopying subclass NSCopying

spouliot · 2017-06-30T02:07:50Z

src/homekit.cs

+ [Watch (4,0), TV (11,0), iOS (11,0)]
+ [BaseType (typeof(HMTimeEvent))]
+ [DisableDefaultCtor]
+ interface HMCalendarEvent : NSCopying, NSMutableCopying {


same NSCopying not needed

spouliot · 2017-06-30T02:10:33Z

src/homekit.cs

+ IntPtr Constructor (NSDateComponents fireDateComponents);
+
+ [Export ("fireDateComponents", ArgumentSemantic.Strong)]
+ NSDateComponents FireDateComponents { get; set; }


don't you get warnings from this ? c# does not allow overriding properties that don't match (no setter vs setter)

the non-mutable version should have both a getter and a setter, the later should be decorated with [NotImplemented]. That solves the issue and makes the code work like expected.

Ok sounds good, but no I did not get any warning (make all in /src).

Isn't the lack of warning due to the fact that we generate: public virtual NSDateComponents FireDateComponents for HMMutableCalendarEvent.g.cs? No override.

weird, double check (with a simple test case) with csc (since pmcs is still mcs based)

@spouliot this is because @VincentDondain is missing [Override] in the property of the mutable objects, he needs

[Export ("fireDateComponents", ArgumentSemantic.Strong)] [Override] NSDateComponents FireDateComponents { get; set; }

Sounds like it could be indeed, I did not know of this attribute, never had to use it. Seemed weird to me that the generated code did not have override.

spouliot · 2017-06-30T02:11:17Z

src/homekit.cs

+ [Watch (4,0), TV (11,0), iOS (11,0)]
+ [BaseType (typeof(HMTimeEvent))]
+ [DisableDefaultCtor]
+ interface HMDurationEvent : NSCopying, NSMutableCopying {


spouliot · 2017-06-30T02:11:41Z

src/homekit.cs

+ IntPtr Constructor (double duration);
+
+ [Export ("duration")]
+ double Duration { get; set; }


same (lack of setter on non-mutable property)

Also needs [Override]

spouliot · 2017-06-30T02:13:26Z

src/homekit.cs

+
+ // FIXME: Bug https://bugzilla.xamarin.com/show_bug.cgi?id=57870
+ // [Wrap ("HMPresenceTypeExtensions.GetValue (_PresenceType)")]
+ // HMPresenceType PresenceType { get; set; }


same (non mutable should expose both)

spouliot · 2017-06-30T02:15:21Z

src/homekit.cs

+ [BaseType (typeof(HMSignificantTimeEvent))]
+ interface HMMutableSignificantTimeEvent {
+
+ [Internal]


not sure it should be internal, it might be needed in some cases (some NSString are user extensible).

Maybe just [Advanced] to hide it (by default) from intelligence ?

spouliot · 2017-06-30T02:15:43Z

src/homekit.cs

+
+ // FIXME: Bug https://bugzilla.xamarin.com/show_bug.cgi?id=57870
+ // [Wrap ("HMSignificantEventExtensions.GetValue (_SignificantEvent)")]
+ // HMSignificantEvent SignificantEvent { get; set; }


same, non mutable version should match signature

monojenkins · 2017-06-30T02:47:46Z

Build failure

monojenkins · 2017-06-30T16:45:43Z

Build failure

monojenkins · 2017-06-30T18:01:14Z

Build failure

dalexsoto

@VincentDondain please verify you have [Override] in your mutable properties

dalexsoto · 2017-06-30T19:56:26Z

src/homekit.cs

@@ -714,6 +735,10 @@ partial interface HMHomeDelegate {
 [Export ("homeDidUpdateName:")]
 void DidUpdateNameForHome (HMHome home);

+ [Watch (4,0), TV (11,0), iOS (11,0)]
+ [Export ("homeDidUpdateAccessControlForCurrentUser:")]
+ void DidUpdateAccessControl (HMHome home);


mmm this is kinda not making sense in my head if home type parameter is ok then let's keep DidUpdateAccessControlForCurrentUser since CurrentUser ctx is lost

I guess you're right, I understood it as the "Home" is the user or represents the user if I give it a bit more thoughts I don't think it's actually the case.

@brief Informs the delegate when the access control for current user has been updated.

dalexsoto · 2017-06-30T20:02:12Z

src/homekit.cs

+ IntPtr Constructor (NSDateComponents fireDateComponents);
+
+ [Export ("fireDateComponents", ArgumentSemantic.Strong)]
+ NSDateComponents FireDateComponents { get; set; }


@spouliot this is because @VincentDondain is missing [Override] in the property of the mutable objects, he needs

[Export ("fireDateComponents", ArgumentSemantic.Strong)] [Override] NSDateComponents FireDateComponents { get; set; }

dalexsoto · 2017-06-30T20:06:00Z

src/homekit.cs

+ IntPtr Constructor (double duration);
+
+ [Export ("duration")]
+ double Duration { get; set; }


Also needs [Override]

monojenkins · 2017-06-30T22:12:20Z

Build failure

VincentDondain · 2017-07-05T15:04:59Z

Unrelated test failure: https://bugzilla.xamarin.com/show_bug.cgi?id=57762

[homekit] Update for Xcode 9 beta 1 & 2

529c3c2

VincentDondain requested review from dalexsoto, rolfbjarne, spouliot and mandel-macaque June 30, 2017 01:33

dnfclas added the cla-already-signed label Jun 30, 2017

spouliot suggested changes Jun 30, 2017

View reviewed changes

rolfbjarne approved these changes Jun 30, 2017

View reviewed changes

VincentDondain and others added 2 commits June 30, 2017 12:40

[homekit] Fixes based on comments (1)

eb07a2a

Merge branch 'xcode9' into homekit-b2

4e67217

dalexsoto requested changes Jun 30, 2017

View reviewed changes

[homekit] Add overrides

09e8115

dalexsoto approved these changes Jun 30, 2017

View reviewed changes

spouliot approved these changes Jul 4, 2017

View reviewed changes

VincentDondain merged commit 9866d3a into xamarin:xcode9 Jul 5, 2017

VincentDondain deleted the homekit-b2 branch July 5, 2017 15:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[homekit] Update for Xcode 9 beta 1 & 2 #2276

[homekit] Update for Xcode 9 beta 1 & 2 #2276

VincentDondain commented Jun 30, 2017

spouliot Jun 30, 2017

VincentDondain Jun 30, 2017

dalexsoto Jun 30, 2017 •

edited

Loading

VincentDondain Jun 30, 2017

dalexsoto Jun 30, 2017

spouliot Jun 30, 2017

spouliot Jun 30, 2017

spouliot Jun 30, 2017

spouliot Jun 30, 2017

VincentDondain Jun 30, 2017

VincentDondain Jun 30, 2017

spouliot Jun 30, 2017

dalexsoto Jun 30, 2017

VincentDondain Jun 30, 2017 •

edited

Loading

spouliot Jun 30, 2017

spouliot Jun 30, 2017

dalexsoto Jun 30, 2017

spouliot Jun 30, 2017

spouliot Jun 30, 2017

spouliot Jun 30, 2017

monojenkins commented Jun 30, 2017

monojenkins commented Jun 30, 2017

monojenkins commented Jun 30, 2017

dalexsoto left a comment

dalexsoto Jun 30, 2017

VincentDondain Jun 30, 2017

dalexsoto Jun 30, 2017

dalexsoto Jun 30, 2017

monojenkins commented Jun 30, 2017

VincentDondain commented Jul 5, 2017


		partial class HMMutablePresenceEvent {

		public HMPresenceType PresenceType {


		partial class HMMutableSignificantTimeEvent {

		public HMSignificantEvent SignificantEvent {

[homekit] Update for Xcode 9 beta 1 & 2 #2276

[homekit] Update for Xcode 9 beta 1 & 2 #2276

Conversation

VincentDondain commented Jun 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dalexsoto Jun 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VincentDondain Jun 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jun 30, 2017

monojenkins commented Jun 30, 2017

monojenkins commented Jun 30, 2017

dalexsoto left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Jun 30, 2017

VincentDondain commented Jul 5, 2017

dalexsoto Jun 30, 2017 •

edited

Loading

VincentDondain Jun 30, 2017 •

edited

Loading