[msbuild] Tweak the codesign logic for iOS Simulator builds

[jstedfast]

Don't always codesign, especially for Xcode 8 which seems to break.

iOS Simulator builds should only be codesigned if they require
Entitlements (signified by RequireProvisionProfile).

[spouliot]

note about commit message: Xcode 8 != iOS 8 - it's the former, not the later, that cause problems

[jstedfast]

Thanks, good catch

[monojenkins]

Build failure

[timrisi]

Looks like tests for extensions/watch apps are failing with the change.

[VincentDondain]

LGTM

[jstedfast]

Looks like the unit tests were wrong (wrongly assuming that sim builds would result in a codesigned executable)

[monojenkins]

Build failure

[jstedfast]

Can someone who understands how to read jenkins output explain why the build failed this time? Looks like none of the unit tests failed to me.

[VincentDondain]

@jstedfast so given the attached test report, only framework-test failed.

• watchOS - simulator failed because of https://github.com/xamarin/maccore/issues/581 (known issue). You can tell because of the run log.

• iOS Unified 32-bits - simulator, iOS Unified 64-bits - simulator and tvOS - simulator crashed.
  See crash log.

I don't think that's related to your PR but you can always run framework-test locally to double check (;

Since I believe there's no precedence for this issue (bugzilla or maccore issues), I'd recommend you file one at https://github.com/xamarin/maccore/issues/new.

[timrisi]

If you hit the Test Report button on the left side in jenkins (https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/5891/Test_Report/) you can see the failure. Generally if you don't have any specific test failures listed, the Test Report will show something indicating what went wrong. In this case, it's not specific tests failing, but the framework-test run is crashing on iOS and tvOS and failing on watchOS

[jstedfast]

Seems possibly related:

Reason: no suitable image found.  Did find:
	/Users/builder/Library/Developer/CoreSimulator/Devices/17A53065-205D-4209-BC51-3B9DB0252878/data/Containers/Bundle/Application/05E3EA14-4809-464A-8D0E-47CCBC9366DE/frameworktest.app/Frameworks/XTest.framework/XTest: required code signature missing for '/Users/builder/Library/Developer/CoreSimulator/Devices/17A53065-205D-4209-BC51-3B9DB0252878/data/Containers/Bundle/Application/05E3EA14-4809-464A-8D0E-47CCBC9366DE/frameworktest.app/Frameworks/XTest.framework/XTest'

[monojenkins]

Build success

[jstedfast]

woohoo!

[spouliot]

We should get @alanmcgovern to test this (from master) before back porting to 15.6

[chamons]

Should we add a manual test to catch this in the future?

[spouliot]

@jstedfast milestone does not match the branch, we need a PR for 15.6 too

[jstedfast]

@spouliot ok, will post a new PR for 15.6